You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ol...@apache.org on 2003/06/12 20:38:59 UTC
cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient ConnectMethod.java
olegk 2003/06/12 11:38:59
Modified: httpclient/src/java/org/apache/commons/httpclient
ConnectMethod.java
Log:
Bug fix #20646 (Via NTLM proxy to SSL Apache/BasicAuth. - worked in may 22nd, but broken in beta1)
Contributed by Oleg Kalnichevski
Reviewed by Adrian Sutton
Revision Changes Path
1.18 +7 -7 jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/ConnectMethod.java
Index: ConnectMethod.java
===================================================================
RCS file: /home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/ConnectMethod.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- ConnectMethod.java 26 May 2003 22:07:22 -0000 1.17
+++ ConnectMethod.java 12 Jun 2003 18:38:59 -0000 1.18
@@ -277,9 +277,7 @@
* @return <code>true</code> if the connection should be closed
*/
protected boolean shouldCloseConnection(HttpConnection conn) {
- if (getStatusCode() != HttpStatus.SC_OK) {
- return true;
- } else {
+ if (getStatusCode() == HttpStatus.SC_OK) {
Header connectionHeader = null;
if (!conn.isTransparent()) {
connectionHeader = getResponseHeader("proxy-connection");
@@ -296,6 +294,8 @@
}
}
return false;
+ } else {
+ return super.shouldCloseConnection(conn);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org