You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Ben Dotte (JIRA)" <ta...@jakarta.apache.org> on 2006/02/22 15:45:38 UTC

[jira] Created: (TAPESTRY-867) Do not display errors or errored field decoration on form refresh

Do not display errors or errored field decoration on form refresh
-----------------------------------------------------------------

         Key: TAPESTRY-867
         URL: http://issues.apache.org/jira/browse/TAPESTRY-867
     Project: Tapestry
        Type: Improvement
  Components: Framework  
    Versions: 4.0    
 Environment: Tapestry 4.0, Tomcat 5.5.9
    Reporter: Ben Dotte


This is related to TAPESTRY-636. When a form's refresh listener is called, client-side validation is bypassed but server-side errors still show up. This becomes a problem if you want to refresh a form but not show any errors. Calling clearErrors() on the validation delegate does get rid of the error messages but it also clears any invalid data entered by the user, which is an unwanted side-affect. While onsite, Howard suggested a fix where errors kept in the validation delegate and errored field decoration would be switched off if the form's refresh listener was called. This would make the refresh listener on Form much more useful. One undesired side-affect might be that if errors are already displayed on the page from a previous form submission and the user does something to refresh the form, the errors would disappear.

USE CASE: The user is filling out a self profile beginning with name and address, mistakenly enters '12e45' for the zip code, and then uploads a photo which automatically refreshes the form for a preview. Errors are displayed about the zip code and the remaining required fields which haven't been filled in only because the user hasn't gotten to them yet. Calling clearErrors() would get rid of the errors, but it would also clear the zip code entered by the user. Ideally, the form should maintain all input and not display any errors during this form refresh.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Updated: (TAPESTRY-867) Do not display errors or errored field decoration on form refresh

Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-867?page=all ]

Jesse Kuhnert updated TAPESTRY-867:
-----------------------------------

    Fix Version/s: 4.2
                       (was: 4.1.1)

With the way the current system works I can't think of a reasonable way to make refresh effectively return the form to the exact state it was in prior to the refresh without a massive overhaul of some of the form logic. 

If all we wanted was to ~not~ decorate the errors by default that might be do-able, but each individual component currently manages input and output of it's own data so more than that will require umm more effort. 

> Do not display errors or errored field decoration on form refresh
> -----------------------------------------------------------------
>
>                 Key: TAPESTRY-867
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-867
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>         Environment: Tapestry 4.0, Tomcat 5.5.9
>            Reporter: Ben Dotte
>         Assigned To: Jesse Kuhnert
>             Fix For: 4.2
>
>
> This is related to TAPESTRY-636. When a form's refresh listener is called, client-side validation is bypassed but server-side errors still show up. This becomes a problem if you want to refresh a form but not show any errors. Calling clearErrors() on the validation delegate does get rid of the error messages but it also clears any invalid data entered by the user, which is an unwanted side-affect. While onsite, Howard suggested a fix where errors kept in the validation delegate and errored field decoration would be switched off if the form's refresh listener was called. This would make the refresh listener on Form much more useful. One undesired side-affect might be that if errors are already displayed on the page from a previous form submission and the user does something to refresh the form, the errors would disappear.
> USE CASE: The user is filling out a self profile beginning with name and address, mistakenly enters '12e45' for the zip code, and then uploads a photo which automatically refreshes the form for a preview. Errors are displayed about the zip code and the remaining required fields which haven't been filled in only because the user hasn't gotten to them yet. Calling clearErrors() would get rid of the errors, but it would also clear the zip code entered by the user. Ideally, the form should maintain all input and not display any errors during this form refresh.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-867) Do not display errors or errored field decoration on form refresh

Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-867?page=all ]

Jesse Kuhnert updated TAPESTRY-867:
-----------------------------------

    Fix Version/s: 4.1.1

> Do not display errors or errored field decoration on form refresh
> -----------------------------------------------------------------
>
>                 Key: TAPESTRY-867
>                 URL: http://issues.apache.org/jira/browse/TAPESTRY-867
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>         Environment: Tapestry 4.0, Tomcat 5.5.9
>            Reporter: Ben Dotte
>         Assigned To: Jesse Kuhnert
>             Fix For: 4.1.1
>
>
> This is related to TAPESTRY-636. When a form's refresh listener is called, client-side validation is bypassed but server-side errors still show up. This becomes a problem if you want to refresh a form but not show any errors. Calling clearErrors() on the validation delegate does get rid of the error messages but it also clears any invalid data entered by the user, which is an unwanted side-affect. While onsite, Howard suggested a fix where errors kept in the validation delegate and errored field decoration would be switched off if the form's refresh listener was called. This would make the refresh listener on Form much more useful. One undesired side-affect might be that if errors are already displayed on the page from a previous form submission and the user does something to refresh the form, the errors would disappear.
> USE CASE: The user is filling out a self profile beginning with name and address, mistakenly enters '12e45' for the zip code, and then uploads a photo which automatically refreshes the form for a preview. Errors are displayed about the zip code and the remaining required fields which haven't been filled in only because the user hasn't gotten to them yet. Calling clearErrors() would get rid of the errors, but it would also clear the zip code entered by the user. Ideally, the form should maintain all input and not display any errors during this form refresh.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Resolved: (TAPESTRY-867) Do not display errors or errored field decoration on form refresh

Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert resolved TAPESTRY-867.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 4.2)
                   4.1.2

Looks like I did this already.  It only calls clearErrors() so actual input should be preserved - when possible.

> Do not display errors or errored field decoration on form refresh
> -----------------------------------------------------------------
>
>                 Key: TAPESTRY-867
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-867
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>         Environment: Tapestry 4.0, Tomcat 5.5.9
>            Reporter: Ben Dotte
>            Assignee: Jesse Kuhnert
>             Fix For: 4.1.2
>
>
> This is related to TAPESTRY-636. When a form's refresh listener is called, client-side validation is bypassed but server-side errors still show up. This becomes a problem if you want to refresh a form but not show any errors. Calling clearErrors() on the validation delegate does get rid of the error messages but it also clears any invalid data entered by the user, which is an unwanted side-affect. While onsite, Howard suggested a fix where errors kept in the validation delegate and errored field decoration would be switched off if the form's refresh listener was called. This would make the refresh listener on Form much more useful. One undesired side-affect might be that if errors are already displayed on the page from a previous form submission and the user does something to refresh the form, the errors would disappear.
> USE CASE: The user is filling out a self profile beginning with name and address, mistakenly enters '12e45' for the zip code, and then uploads a photo which automatically refreshes the form for a preview. Errors are displayed about the zip code and the remaining required fields which haven't been filled in only because the user hasn't gotten to them yet. Calling clearErrors() would get rid of the errors, but it would also clear the zip code entered by the user. Ideally, the form should maintain all input and not display any errors during this form refresh.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Assigned: (TAPESTRY-867) Do not display errors or errored field decoration on form refresh

Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-867?page=all ]

Jesse Kuhnert reassigned TAPESTRY-867:
--------------------------------------

    Assign To: Jesse Kuhnert

> Do not display errors or errored field decoration on form refresh
> -----------------------------------------------------------------
>
>          Key: TAPESTRY-867
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-867
>      Project: Tapestry
>         Type: Improvement
>   Components: Framework
>     Versions: 4.0
>  Environment: Tapestry 4.0, Tomcat 5.5.9
>     Reporter: Ben Dotte
>     Assignee: Jesse Kuhnert

>
> This is related to TAPESTRY-636. When a form's refresh listener is called, client-side validation is bypassed but server-side errors still show up. This becomes a problem if you want to refresh a form but not show any errors. Calling clearErrors() on the validation delegate does get rid of the error messages but it also clears any invalid data entered by the user, which is an unwanted side-affect. While onsite, Howard suggested a fix where errors kept in the validation delegate and errored field decoration would be switched off if the form's refresh listener was called. This would make the refresh listener on Form much more useful. One undesired side-affect might be that if errors are already displayed on the page from a previous form submission and the user does something to refresh the form, the errors would disappear.
> USE CASE: The user is filling out a self profile beginning with name and address, mistakenly enters '12e45' for the zip code, and then uploads a photo which automatically refreshes the form for a preview. Errors are displayed about the zip code and the remaining required fields which haven't been filled in only because the user hasn't gotten to them yet. Calling clearErrors() would get rid of the errors, but it would also clear the zip code entered by the user. Ideally, the form should maintain all input and not display any errors during this form refresh.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org