You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2024/06/13 19:46:07 UTC

[PR] [HUDI-7875] remove tablepath from fg reader [hudi]

jonvex opened a new pull request, #11453:
URL: https://github.com/apache/hudi/pull/11453

   ### Change Logs
   
   now we get the table path from the meta client. Also we will pass the meta client through the reader context to reduce the params of the record buffers.
   
   ### Impact
   
   easier for new engines to implement fg reader
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex closed pull request #11453: [HUDI-7875] remove tablepath from fg reader
URL: https://github.com/apache/hudi/pull/11453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2166782661

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82a4d6fb2c3cd0aa353c028d15659427eec4962 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386) 
   * b06455ddb5402cbb0d7df375b7595277f8b0eab9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2170629872

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422",
       "triggerID" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b06455ddb5402cbb0d7df375b7595277f8b0eab9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388) 
   * d3636b6efd78b21f8a7ed1c169b1c9616eb9009d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2166672996

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82a4d6fb2c3cd0aa353c028d15659427eec4962 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2166794958

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82a4d6fb2c3cd0aa353c028d15659427eec4962 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386) 
   * b06455ddb5402cbb0d7df375b7595277f8b0eab9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2170618729

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b06455ddb5402cbb0d7df375b7595277f8b0eab9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388) 
   * d3636b6efd78b21f8a7ed1c169b1c9616eb9009d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2289207862

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422",
       "triggerID" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74b6a0dc95fb9382618615f3992157d9265ada82",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=37",
       "triggerID" : "74b6a0dc95fb9382618615f3992157d9265ada82",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3636b6efd78b21f8a7ed1c169b1c9616eb9009d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422) 
   * 74b6a0dc95fb9382618615f3992157d9265ada82 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=37) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2166659296

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d82a4d6fb2c3cd0aa353c028d15659427eec4962 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2170937323

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422",
       "triggerID" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3636b6efd78b21f8a7ed1c169b1c9616eb9009d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #11453:
URL: https://github.com/apache/hudi/pull/11453#discussion_r1717932624


##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -72,15 +73,16 @@ public void setSchemaHandler(HoodieFileGroupReaderSchemaHandler<T> schemaHandler
     this.schemaHandler = schemaHandler;
   }
 
-  public String getTablePath() {
-    if (tablePath == null) {
-      throw new IllegalStateException("Table path not set in reader context.");
-    }
-    return tablePath;
+  public StoragePath getTablePath() {
+    return metaClient.getBasePath();

Review Comment:
   Verify that meta client is set and non-null?



##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -105,7 +103,7 @@ public HoodieFileGroupReader(HoodieReaderContext<T> readerContext,
     HoodieTableConfig tableConfig = hoodieTableMetaClient.getTableConfig();
     this.recordMerger = readerContext.getRecordMerger(tableConfig.getRecordMergerStrategy());
     readerContext.setRecordMerger(this.recordMerger);

Review Comment:
   Could you file a follow-up ticket to refactor the reader context construction?  It's still an anti-pattern to allow any setters which make it mutable and not safe.



##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -72,15 +73,16 @@ public void setSchemaHandler(HoodieFileGroupReaderSchemaHandler<T> schemaHandler
     this.schemaHandler = schemaHandler;
   }
 
-  public String getTablePath() {
-    if (tablePath == null) {
-      throw new IllegalStateException("Table path not set in reader context.");
-    }
-    return tablePath;
+  public StoragePath getTablePath() {
+    return metaClient.getBasePath();
+  }
+
+  public HoodieTableMetaClient getMetaClient() {
+    return metaClient;
   }
 
-  public void setTablePath(String tablePath) {
-    this.tablePath = tablePath;
+  public void setMetaClient(HoodieTableMetaClient metaClient) {

Review Comment:
   `HoodieReaderContext` is meant to handle only engine-specific implementation on reading data files, getting field values from a record, transforming a record, etc., but now it's getting more and more complex and hard to maintain by mixing Hudi-specific logic which should be completely avoided.  Keep this in mind.  If you need to have common logic for Hudi-specific logic, let's add a new class that can be used across engines without any changes, just like `HoodieFileGroupReader`, and keep this class lean.



##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -72,15 +73,16 @@ public void setSchemaHandler(HoodieFileGroupReaderSchemaHandler<T> schemaHandler
     this.schemaHandler = schemaHandler;
   }
 
-  public String getTablePath() {
-    if (tablePath == null) {
-      throw new IllegalStateException("Table path not set in reader context.");
-    }
-    return tablePath;
+  public StoragePath getTablePath() {
+    return metaClient.getBasePath();
+  }
+
+  public HoodieTableMetaClient getMetaClient() {
+    return metaClient;
   }
 
-  public void setTablePath(String tablePath) {
-    this.tablePath = tablePath;
+  public void setMetaClient(HoodieTableMetaClient metaClient) {

Review Comment:
   Rethinking this, should we keep meta client out of the reader context?



##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -72,15 +73,16 @@ public void setSchemaHandler(HoodieFileGroupReaderSchemaHandler<T> schemaHandler
     this.schemaHandler = schemaHandler;
   }
 
-  public String getTablePath() {
-    if (tablePath == null) {
-      throw new IllegalStateException("Table path not set in reader context.");
-    }
-    return tablePath;
+  public StoragePath getTablePath() {
+    return metaClient.getBasePath();
+  }
+
+  public HoodieTableMetaClient getMetaClient() {
+    return metaClient;
   }
 
-  public void setTablePath(String tablePath) {
-    this.tablePath = tablePath;
+  public void setMetaClient(HoodieTableMetaClient metaClient) {

Review Comment:
   Could you file a ticket on this as a follow-up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2289205425

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422",
       "triggerID" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74b6a0dc95fb9382618615f3992157d9265ada82",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "74b6a0dc95fb9382618615f3992157d9265ada82",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3636b6efd78b21f8a7ed1c169b1c9616eb9009d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422) 
   * 74b6a0dc95fb9382618615f3992157d9265ada82 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2289392672

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24422",
       "triggerID" : "d3636b6efd78b21f8a7ed1c169b1c9616eb9009d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74b6a0dc95fb9382618615f3992157d9265ada82",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=37",
       "triggerID" : "74b6a0dc95fb9382618615f3992157d9265ada82",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74b6a0dc95fb9382618615f3992157d9265ada82 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=37) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7875] remove tablepath from fg reader [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11453:
URL: https://github.com/apache/hudi/pull/11453#issuecomment-2166917349

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24386",
       "triggerID" : "d82a4d6fb2c3cd0aa353c028d15659427eec4962",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388",
       "triggerID" : "b06455ddb5402cbb0d7df375b7595277f8b0eab9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b06455ddb5402cbb0d7df375b7595277f8b0eab9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24388) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org