You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/08 07:33:40 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1489: e2e: support docker hub as registry
tao12345666333 commented on code in PR #1489:
URL: https://github.com/apache/apisix-ingress-controller/pull/1489#discussion_r1043012791
##########
.github/workflows/e2e-test-ci-v2-cron.yml:
##########
@@ -108,12 +108,12 @@ jobs:
echo "creating images cache..."
docker save \
- localhost:5000/apache/apisix:dev \
- localhost:5000/bitnami/etcd:dev \
- localhost:5000/apache/apisix-ingress-controller:dev \
- localhost:5000/kennethreitz/httpbin:dev \
+ localhost:5000/apisix:dev \
+ localhost:5000/etcd:dev \
+ localhost:5000/apisix-ingress-controller:dev \
+ localhost:5000/httpbin:dev \
localhost:5000/test-backend:dev \
- localhost:5000/jmalloc/echo-server:dev \
+ localhost:5000/echo-server:dev \
Review Comment:
It would be more intuitive for us to replace $REGISTRY here. WDYT?
##########
.github/workflows/e2e-test-ci.yml:
##########
@@ -107,12 +107,12 @@ jobs:
echo "creating images cache..."
docker save \
- localhost:5000/apache/apisix:dev \
- localhost:5000/bitnami/etcd:dev \
- localhost:5000/apache/apisix-ingress-controller:dev \
- localhost:5000/kennethreitz/httpbin:dev \
+ localhost:5000/apisix:dev \
+ localhost:5000/etcd:dev \
+ localhost:5000/apisix-ingress-controller:dev \
+ localhost:5000/httpbin:dev \
localhost:5000/test-backend:dev \
- localhost:5000/jmalloc/echo-server:dev \
+ localhost:5000/echo-server:dev \
Review Comment:
ditto
##########
test/e2e/scaffold/apisix.go:
##########
@@ -72,7 +72,7 @@ spec:
tcpSocket:
port: 9080
timeoutSeconds: 2
- image: "localhost:5000/apache/apisix:dev"
+ image: "localhost:5000/apisix:dev"
Review Comment:
We could also add a global variable that stores the $REGISTRY used instead of hardcoding it here.
##########
.github/workflows/k8s-timer-ci.yml:
##########
@@ -97,12 +97,12 @@ jobs:
echo "creating images cache..."
docker save \
- localhost:5000/apache/apisix:dev \
- localhost:5000/bitnami/etcd:dev \
- localhost:5000/apache/apisix-ingress-controller:dev \
- localhost:5000/kennethreitz/httpbin:dev \
+ localhost:5000/apisix:dev \
+ localhost:5000/etcd:dev \
+ localhost:5000/apisix-ingress-controller:dev \
+ localhost:5000/httpbin:dev \
localhost:5000/test-backend:dev \
- localhost:5000/jmalloc/echo-server:dev \
+ localhost:5000/echo-server:dev \
localhost:5000/busybox:dev \
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org