You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by " Gianandrea Rigoni (Jira)" <ji...@apache.org> on 2020/01/21 20:35:00 UTC

[jira] [Commented] (CAMEL-14414) Aggregation completion has inconsistent property/header handling

    [ https://issues.apache.org/jira/browse/CAMEL-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020547#comment-17020547 ] 

 Gianandrea Rigoni commented on CAMEL-14414:
--------------------------------------------

hi [~cibsen@e-ma.net]
one reason for my PR is to fix a side effect that happens when using AGGREGATION_COMPLETE_CURRENT_GROUP and AGGREGATION_COMPLETE_ALL_GROUPS
the header/property is not cleaned up and it survives being propagated to following routes, for example a second aggregation chained to one which has group completion
therefore instead of improvement this should be considered as a bug

also see: CAMEL-12589

kind regards

> Aggregation completion has inconsistent property/header handling
> ----------------------------------------------------------------
>
>                 Key: CAMEL-14414
>                 URL: https://issues.apache.org/jira/browse/CAMEL-14414
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.24.3, 3.x
>            Reporter:  Gianandrea Rigoni
>            Priority: Major
>             Fix For: 3.x
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> following headers or properties are handled in an inconsistent way
> sometimes setted as prop then removed as headers or viceversa
> documentation in describing how to set them is also slightly inconsistent
> affected flags are (I am on purpose avoiding naming them header or property)
> AGGREGATION_COMPLETE_CURRENT_GROUP
> AGGREGATION_COMPLETE_ALL_GROUPS
> AGGREGATION_COMPLETE_ALL_GROUPS_INCLUSIVE
> also chaining aggregations is not working when using 
> AGGREGATION_COMPLETE_CURRENT_GROUP
> AGGREGATION_COMPLETE_ALL_GROUPS
> because setting is done on prop and removal is done on header level
> I have created a PR proposing a change



--
This message was sent by Atlassian Jira
(v8.3.4#803005)