You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "PatrickRen (via GitHub)" <gi...@apache.org> on 2024/03/19 09:10:41 UTC
[PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
PatrickRen opened a new pull request, #3169:
URL: https://github.com/apache/flink-cdc/pull/3169
This pull request synchronized Chinese documentations for Flink CDC, to fully match English docs. Translations will be made by followup PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "PatrickRen (via GitHub)" <gi...@apache.org>.
PatrickRen commented on code in PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#discussion_r1530024863
##########
docs/content.zh/docs/get-started/quickstart/mysql-to-doris.md:
##########
@@ -26,7 +26,7 @@ under the License.
# Streaming ELT from MySQL to Doris
-This tutorial is to show how to quickly build a Streaming ELT job from MySQL to Doris using Flink CDC, including the
+This tutorial is to show how to quickly build a Streaming ELT job from MySQL to StarRocks using Flink CDC, including the
Review Comment:
Fixed in the followup commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#discussion_r1530020610
##########
docs/content.zh/docs/get-started/quickstart/mysql-to-doris.md:
##########
@@ -26,7 +26,7 @@ under the License.
# Streaming ELT from MySQL to Doris
-This tutorial is to show how to quickly build a Streaming ELT job from MySQL to Doris using Flink CDC, including the
+This tutorial is to show how to quickly build a Streaming ELT job from MySQL to StarRocks using Flink CDC, including the
Review Comment:
> Good catch! I just copy all documentations from `docs/content/docs` to `docs/content.zh/docs`. We need to trace back to the original author
Looks like I made the typo, o(╯□╰)o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "gtk96 (via GitHub)" <gi...@apache.org>.
gtk96 commented on code in PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#discussion_r1529992363
##########
docs/content.zh/docs/get-started/quickstart/mysql-to-doris.md:
##########
@@ -26,7 +26,7 @@ under the License.
# Streaming ELT from MySQL to Doris
-This tutorial is to show how to quickly build a Streaming ELT job from MySQL to Doris using Flink CDC, including the
+This tutorial is to show how to quickly build a Streaming ELT job from MySQL to StarRocks using Flink CDC, including the
Review Comment:
For what reason have modifications been made here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "gtk96 (via GitHub)" <gi...@apache.org>.
gtk96 commented on PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#issuecomment-2006529558
@PatrickRen Outstanding contribution, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#discussion_r1530017327
##########
docs/content.zh/docs/developer-guide/licenses.md:
##########
@@ -24,15 +24,15 @@ specific language governing permissions and limitations
under the License.
-->
Review Comment:
Could we keep this Chinese doc instead fo override it?
##########
docs/content.zh/docs/developer-guide/contribute-to-flink-cdc.md:
##########
@@ -24,56 +24,61 @@ specific language governing permissions and limitations
under the License.
-->
-# 社区贡献
+# Contributing
Review Comment:
Could we keep this Chinese doc instead fo override it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "PatrickRen (via GitHub)" <gi...@apache.org>.
PatrickRen merged PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "PatrickRen (via GitHub)" <gi...@apache.org>.
PatrickRen commented on code in PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#discussion_r1530015148
##########
docs/content.zh/docs/get-started/quickstart/mysql-to-doris.md:
##########
@@ -26,7 +26,7 @@ under the License.
# Streaming ELT from MySQL to Doris
-This tutorial is to show how to quickly build a Streaming ELT job from MySQL to Doris using Flink CDC, including the
+This tutorial is to show how to quickly build a Streaming ELT job from MySQL to StarRocks using Flink CDC, including the
Review Comment:
Good catch! I just copy all documentations from `docs/content/docs` to `docs/content.zh/docs`. We need to trace back to the original author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#discussion_r1530015268
##########
docs/content.zh/docs/get-started/quickstart/mysql-to-doris.md:
##########
@@ -26,7 +26,7 @@ under the License.
# Streaming ELT from MySQL to Doris
-This tutorial is to show how to quickly build a Streaming ELT job from MySQL to Doris using Flink CDC, including the
+This tutorial is to show how to quickly build a Streaming ELT job from MySQL to StarRocks using Flink CDC, including the
Review Comment:
+1
> For what reason have modifications been made here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "gtk96 (via GitHub)" <gi...@apache.org>.
gtk96 commented on PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#issuecomment-2006549340
@leonardBang https://github.com/apache/flink-cdc/blob/master/docs/content/docs/get-started/quickstart/mysql-to-doris.md We also need a small patch here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#discussion_r1530021065
##########
docs/content.zh/docs/get-started/quickstart/mysql-to-doris.md:
##########
@@ -26,7 +26,7 @@ under the License.
# Streaming ELT from MySQL to Doris
-This tutorial is to show how to quickly build a Streaming ELT job from MySQL to Doris using Flink CDC, including the
+This tutorial is to show how to quickly build a Streaming ELT job from MySQL to StarRocks using Flink CDC, including the
Review Comment:
Please help fix it，sir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC [flink-cdc]
Posted by "PatrickRen (via GitHub)" <gi...@apache.org>.
PatrickRen commented on PR #3169:
URL: https://github.com/apache/flink-cdc/pull/3169#issuecomment-2006567610
@gtk96 It has been fixed in my followup commit [2646d2f](https://github.com/apache/flink-cdc/pull/3169/commits/2646d2faebe5e17beb193a2e047480e490883155)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org