You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/06/09 19:16:40 UTC
Review Request 35257: Decode network statistics from helper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35257/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332
Repository: mesos
Description
-------
Decode network statistics from helper
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
Diff: https://reviews.apache.org/r/35257/diff/
Testing
-------
'sudo make check' for backward compatability
Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review.
Thanks,
Paul Brett
Re: Review Request 35257: Decode network statistics from helper
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35257/#review87244
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35225, 35229, 35257]
All tests passed.
- Mesos ReviewBot
On June 9, 2015, 5:16 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35257/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 5:16 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2332
> https://issues.apache.org/jira/browse/MESOS-2332
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Decode network statistics from helper
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
>
> Diff: https://reviews.apache.org/r/35257/diff/
>
>
> Testing
> -------
>
> 'sudo make check' for backward compatability
>
> Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review.
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35257: Decode network statistics from helper
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35257/#review88300
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On June 16, 2015, 10:22 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35257/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 10:22 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2837
> https://issues.apache.org/jira/browse/MESOS-2837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Decode network statistics from helper
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp e55e7b62bc29125458f9c0fb5477057ecc5a90df
>
> Diff: https://reviews.apache.org/r/35257/diff/
>
>
> Testing
> -------
>
> 'sudo make check' for backward compatability
>
> Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review.
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35257: Decode network statistics from helper
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35257/#review88190
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35536, 35229, 35257]
All tests passed.
- Mesos ReviewBot
On June 16, 2015, 10:22 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35257/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 10:22 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2837
> https://issues.apache.org/jira/browse/MESOS-2837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Decode network statistics from helper
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp e55e7b62bc29125458f9c0fb5477057ecc5a90df
>
> Diff: https://reviews.apache.org/r/35257/diff/
>
>
> Testing
> -------
>
> 'sudo make check' for backward compatability
>
> Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review.
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35257: Decode network statistics from helper
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35257/
-----------------------------------------------------------
(Updated June 16, 2015, 10:22 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2837
https://issues.apache.org/jira/browse/MESOS-2837
Repository: mesos
Description
-------
Decode network statistics from helper
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp e55e7b62bc29125458f9c0fb5477057ecc5a90df
Diff: https://reviews.apache.org/r/35257/diff/
Testing
-------
'sudo make check' for backward compatability
Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review.
Thanks,
Paul Brett
Re: Review Request 35257: Decode network statistics from helper
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35257/
-----------------------------------------------------------
(Updated June 9, 2015, 9:55 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2837
https://issues.apache.org/jira/browse/MESOS-2837
Repository: mesos
Description
-------
Decode network statistics from helper
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
Diff: https://reviews.apache.org/r/35257/diff/
Testing
-------
'sudo make check' for backward compatability
Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review.
Thanks,
Paul Brett