You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/01 08:11:27 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request, #15874: [improve][client]Remove unnecessary bitset set and clear operation
gaozhangmin opened a new pull request, #15874:
URL: https://github.com/apache/pulsar/pull/15874
### Motivation
A new bit set is created with all bits are initially set false.
There is no need to set then clear bitset index when doing doCumulativeBatchIndexAck
### Modifications
Remove unnecessary bitset operation
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15874: [improve][client]Remove unnecessary bitset set and clear operation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/pulsar/pull/15874#issuecomment-1143287999
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin closed pull request #15874: [improve][client]Remove unnecessary bitset set and clear operation
Posted by GitBox <gi...@apache.org>.
gaozhangmin closed pull request #15874: [improve][client]Remove unnecessary bitset set and clear operation
URL: https://github.com/apache/pulsar/pull/15874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15874: [improve][client]Remove unnecessary bitset set and clear operation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/pulsar/pull/15874#issuecomment-1143288816
@gaozhangmin:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15874: [improve][client]Remove unnecessary bitset set and clear operation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/pulsar/pull/15874#issuecomment-1143289378
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org