You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/18 09:53:28 UTC

[GitHub] [rocketmq-client-go] superhx opened a new pull request, #895: (feat): add user defined topic dimension consumer limiter

superhx opened a new pull request, #895:
URL: https://github.com/apache/rocketmq-client-go/pull/895

   ## What is the purpose of the change
   
   Add user defined consume rate limiter which is topic dimension. The user could use self defined Limiter 'block' consume to controller topic consume rate based on  TPS / Concurrent / Load or any other condition.
   
   ## Brief changelog
   - add consumer Limiter func definition.
   - add Limiter to push_consumer#consumeMessageCurrently 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] ShannonDing merged pull request #895: (feat): add user defined topic dimension consumer limiter

Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #895:
URL: https://github.com/apache/rocketmq-client-go/pull/895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] superhx closed pull request #895: (feat): add user defined topic dimension consumer limiter

Posted by GitBox <gi...@apache.org>.
superhx closed pull request #895: (feat): add user defined topic dimension consumer limiter
URL: https://github.com/apache/rocketmq-client-go/pull/895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #895: (feat): add user defined topic dimension consumer limiter

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #895:
URL: https://github.com/apache/rocketmq-client-go/pull/895#issuecomment-1219418851

   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/895?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#895](https://codecov.io/gh/apache/rocketmq-client-go/pull/895?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ef0fd5) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/1c75f2388f8137a30e3c2cdfb14c5c65b8c20e07?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c75f23) will **decrease** coverage by `0.08%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #895      +/-   ##
   ==========================================
   - Coverage   23.81%   23.73%   -0.09%     
   ==========================================
     Files          52       52              
     Lines        7105     7129      +24     
   ==========================================
     Hits         1692     1692              
   - Misses       5187     5211      +24     
     Partials      226      226              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [consumer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/895/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvb3B0aW9uLmdv) | `20.33% <0.00%> (-0.54%)` | :arrow_down: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/895/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.78% <0.00%> (-0.11%)` | :arrow_down: |
   | [internal/utils/namespace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/895/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdXRpbHMvbmFtZXNwYWNlLmdv) | `0.00% <0.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org