You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2026/02/04 19:58:00 UTC
[PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
alinaliBQ opened a new pull request, #49151:
URL: https://github.com/apache/arrow/pull/49151
### Rationale for this change
#49092
### What changes are included in this PR?
- Add `dev-yyyy-mm-dd` to ODBC MSI name.
Before: `Apache Arrow Flight SQL ODBC-1.0.0-win64.msi`. After: `Apache Arrow Flight SQL ODBC-1.0.0-dev-2026-02-04-win64.msi`.
### Are these changes tested?
Tested in CI.
### Are there any user-facing changes?
Yes, the nightly ODBC file names will be changed as described above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49151:
URL: https://github.com/apache/arrow/pull/49151#discussion_r2771817381
##########
.github/workflows/cpp_extra.yml:
##########
@@ -472,6 +472,14 @@ jobs:
run: |
mkdir odbc-installer
mv *.msi odbc-installer/
+
+ # Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`
Review Comment:
How about adding an example for easy to understand?
```suggestion
# Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`:
# Apache Arrow Flight SQL ODBC-24.0.0-win64.msi ->
# Apache Arrow Flight SQL ODBC-24.0.0-dev-2026-02-06-win64.msi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49151:
URL: https://github.com/apache/arrow/pull/49151#discussion_r2771817381
##########
.github/workflows/cpp_extra.yml:
##########
@@ -472,6 +472,14 @@ jobs:
run: |
mkdir odbc-installer
mv *.msi odbc-installer/
+
+ # Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`
Review Comment:
```suggestion
# Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`:
# Apache Arrow Flight SQL ODBC-24.0.0-win64.msi ->
# Apache Arrow Flight SQL ODBC-24.0.0-dev-2026-02-06-win64.msi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49151:
URL: https://github.com/apache/arrow/pull/49151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #49151:
URL: https://github.com/apache/arrow/pull/49151#discussion_r2771393963
##########
.github/workflows/cpp_extra.yml:
##########
@@ -472,6 +472,20 @@ jobs:
run: |
mkdir odbc-installer
mv *.msi odbc-installer/
+
+ # Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`
+ cd odbc-installer
+ msi_name=$(ls *.msi)
+ echo $msi_name
+ SUFFIX=dev-$(date +%Y-%m-%d)-
+ echo $SUFFIX
+ INDEX=${#msi_name}-9
+ dev_msi_name="${msi_name:0:$INDEX}${SUFFIX}${msi_name:$INDEX}"
+ echo $msi_name
+ echo $dev_msi_name
Review Comment:
Thanks a lot @kou, I have tested the command locally and applied the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49151:
URL: https://github.com/apache/arrow/pull/49151#issuecomment-3849567352
Hi @raulcd @kou This PR for renaming ODBC for Nightly package is ready for review. 🙂
cc @amoeba @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49151:
URL: https://github.com/apache/arrow/pull/49151#discussion_r2766618675
##########
.github/workflows/cpp_extra.yml:
##########
@@ -472,6 +472,20 @@ jobs:
run: |
mkdir odbc-installer
mv *.msi odbc-installer/
+
+ # Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`
+ cd odbc-installer
+ msi_name=$(ls *.msi)
+ echo $msi_name
+ SUFFIX=dev-$(date +%Y-%m-%d)-
+ echo $SUFFIX
+ INDEX=${#msi_name}-9
+ dev_msi_name="${msi_name:0:$INDEX}${SUFFIX}${msi_name:$INDEX}"
+ echo $msi_name
+ echo $dev_msi_name
Review Comment:
How about using `sed`?
```suggestion
msi_name=$(ls *.msi)
dev_msi_name=$(echo ${msi_name} | sed -e "s/win64\.msi$/dev-$(date +%Y-%m-%d)-win64.msi/")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49151:
URL: https://github.com/apache/arrow/pull/49151#discussion_r2771817381
##########
.github/workflows/cpp_extra.yml:
##########
@@ -472,6 +472,14 @@ jobs:
run: |
mkdir odbc-installer
mv *.msi odbc-installer/
+
+ # Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`
Review Comment:
How about adding an example?
```suggestion
# Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`:
# Apache Arrow Flight SQL ODBC-24.0.0-win64.msi ->
# Apache Arrow Flight SQL ODBC-24.0.0-dev-2026-02-06-win64.msi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49092: [C++][FlightRPC][CI] Nightly Packaging: Add `dev-yyyy-mm-dd` to ODBC MSI name [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #49151:
URL: https://github.com/apache/arrow/pull/49151#discussion_r2771828370
##########
.github/workflows/cpp_extra.yml:
##########
@@ -472,6 +472,14 @@ jobs:
run: |
mkdir odbc-installer
mv *.msi odbc-installer/
+
+ # Add `dev-yyyy-mm-dd` to ODBC MSI before `win64.msi`
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org