[GitHub] [spark] zekai-li commented on a diff in pull request #42529: [SPARK-44845][YARN][DEPLOY]Fixed file system uri comparison function

["zekai-li (via GitHub)" <gi...@apache.org>]

zekai-li commented on code in PR #42529:
URL: https://github.com/apache/spark/pull/42529#discussion_r1299504495


##########
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:
##########
@@ -670,7 +670,7 @@ class ClientSuite extends SparkFunSuite with Matchers {
     ("files URI match test1", "file:///file1", "file:///file2"),
     ("files URI match test2", "file:///c:file1", "file://c:file2"),
     ("files URI match test3", "file://host/file1", "file://host/file2"),
-    ("wasb URI match test", "wasb://bucket1@user", "wasb://bucket1@user/"),
+    ("wasb URI match test", "wasb://user@bucket1", "wasb://user@bucket1/"),

Review Comment:
   It makes sense that wasb is a special case for host, but it does not violate the original uri. The main problem I'm referring to is that s3 writes the password in the wrong place, and I can't find a way to write it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org