You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/18 13:25:42 UTC
[GitHub] [lucene] dweiss commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.
dweiss commented on code in PR #900:
URL: https://github.com/apache/lucene/pull/900#discussion_r875894329
##########
lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java:
##########
@@ -582,23 +589,29 @@ public MergeSpecification findMerges(
if (anyMerging) {
// skip
} else if (!anyTooLarge) {
- if (spec == null) spec = new MergeSpecification();
- final List<SegmentCommitInfo> mergeInfos = new ArrayList<>(end - start);
- for (int i = start; i < end; i++) {
- mergeInfos.add(levels.get(i).info);
- assert infos.contains(levels.get(i).info);
- }
- if (verbose(mergeContext)) {
- message(
- " add merge="
- + segString(mergeContext, mergeInfos)
- + " start="
- + start
- + " end="
- + end,
- mergeContext);
- }
- spec.add(new OneMerge(mergeInfos));
+ if (mergeSize >= maxSegmentSize * 1.5) {
+ // Ignore any merge where the resulting segment is not at least 50% larger than the
+ // biggest input segment.
+ // Otherwise we could run into pathological O(N^2) merging where merges keep rewriting
+ // again and again the biggest input segment into a segment that is barely bigger.
+ if (spec == null) spec = new MergeSpecification();
Review Comment:
spotless doesn't add code (add brackets, etc.) - it merely rewraps existing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org