[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2010: DRILL-7620: Fix plugin mutability issues

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #2010: DRILL-7620: Fix plugin mutability issues
URL: https://github.com/apache/drill/pull/2010#discussion_r387643809
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java
 ##########
 @@ -91,14 +121,35 @@
   Map<String, StoragePluginConfig> enabledConfigs();
 
   /**
-   * Get the Format plugin for the FileSystemPlugin associated with the provided storage config and format config.
+   * Safe way to add or remove a format plugin config from a stored file
+   * system configuration. Makes a copy of the config, adds/removes the
+   * format plugin, and updates the persistent store with the copy.
+   *
+   * @param pluginName name of the file system storage plugin config to
+   * modify
+   * @param formatName name of the format plugin to modify
+   * @param formatConfig if null, removes the plugin, if non-null updates
+   * the format plugin config with this value
+   * @throws ExecutionSetupException if the stoage plugin is undefined or
 
 Review comment:
   ```suggestion
      * @throws ExecutionSetupException if the storage plugin is undefined or
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services