You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/01 09:12:37 UTC

[GitHub] [apisix] Firstsawyou opened a new pull request #3713: docs: update request-id.md doc

Firstsawyou opened a new pull request #3713:
URL: https://github.com/apache/apisix/pull/3713


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   Fix the configuration example uri of the request-id.md document is inconsistent with the test uri, and the response data of the test request is added with the `X-Request-Id` header.
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #3713: docs: update request-id.md doc

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3713:
URL: https://github.com/apache/apisix/pull/3713


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3713: docs: update request-id.md doc

Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #3713:
URL: https://github.com/apache/apisix/pull/3713#discussion_r584584470



##########
File path: docs/en/latest/plugins/request-id.md
##########
@@ -68,6 +68,13 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13
 ```shell
 $ curl -i http://127.0.0.1:9080/hello
 HTTP/1.1 200 OK
+Content-Type: application/octet-stream
+Transfer-Encoding: chunked
+Connection: keep-alive
+Date: Mon, 01 Mar 2021 09:00:25 GMT
+Server: APISIX/2.3
+X-Request-Id: fe32076a-d0a5-49a6-a361-6c244c1df956

Review comment:
       agree, updared.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3713: docs: update request-id.md doc

Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #3713:
URL: https://github.com/apache/apisix/pull/3713#discussion_r584584470



##########
File path: docs/en/latest/plugins/request-id.md
##########
@@ -68,6 +68,13 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13
 ```shell
 $ curl -i http://127.0.0.1:9080/hello
 HTTP/1.1 200 OK
+Content-Type: application/octet-stream
+Transfer-Encoding: chunked
+Connection: keep-alive
+Date: Mon, 01 Mar 2021 09:00:25 GMT
+Server: APISIX/2.3
+X-Request-Id: fe32076a-d0a5-49a6-a361-6c244c1df956

Review comment:
       agree, updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3713: docs: update request-id.md doc

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3713:
URL: https://github.com/apache/apisix/pull/3713#discussion_r584577746



##########
File path: docs/en/latest/plugins/request-id.md
##########
@@ -68,6 +68,13 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13
 ```shell
 $ curl -i http://127.0.0.1:9080/hello
 HTTP/1.1 200 OK
+Content-Type: application/octet-stream
+Transfer-Encoding: chunked
+Connection: keep-alive
+Date: Mon, 01 Mar 2021 09:00:25 GMT
+Server: APISIX/2.3
+X-Request-Id: fe32076a-d0a5-49a6-a361-6c244c1df956

Review comment:
       Should we only show the `X-Request-Id`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org