[GitHub] [airflow] mik-laj commented on a change in pull request #9330: Add read-only Task endpoint

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #9330:
URL: https://github.com/apache/airflow/pull/9330#discussion_r440835127



##########
File path: airflow/api_connexion/schemas/common_schema.py
##########
@@ -0,0 +1,145 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import datetime
+import inspect
+import typing
+from functools import partial
+
+import marshmallow
+from dateutil import relativedelta
+from marshmallow import Schema, fields, validate
+from marshmallow_oneofschema import OneOfSchema
+
+from airflow.utils.weight_rule import WeightRule
+
+
+class CronExpression(typing.NamedTuple):
+    """Cron expression schema"""
+    value: str
+
+
+class TimeDeltaSchema(Schema):
+    """Time delta schema"""
+
+    objectType = fields.Constant("TimeDelta", dump_to="__type")
+    days = fields.Integer()
+    seconds = fields.Integer()
+    microsecond = fields.Integer()
+
+    @marshmallow.post_load
+    def make_time_delta(self, data, **kwargs):
+        """Create time delta based on data"""
+
+        if "objectType" in data:
+            del data["objectType"]
+        return datetime.timedelta(**data)
+
+
+class RelativeDeltaSchema(Schema):
+    """Relative delta schema"""
+
+    objectType = fields.Constant("RelativeDelta", dump_to="__type")
+    years = fields.Integer()
+    months = fields.Integer()
+    days = fields.Integer()
+    leapdays = fields.Integer()
+    hours = fields.Integer()
+    minutes = fields.Integer()
+    seconds = fields.Integer()
+    microseconds = fields.Integer()
+    year = fields.Integer()
+    month = fields.Integer()
+    day = fields.Integer()
+    hour = fields.Integer()
+    minute = fields.Integer()
+    second = fields.Integer()
+    microsecond = fields.Integer()
+
+    @marshmallow.post_load
+    def make_relative_delta(self, data, **kwargs):
+        """Create relative delta based on data"""
+
+        if "objectType" in data:
+            del data["objectType"]
+
+        return relativedelta.relativedelta(**data)
+
+
+class CronExpressionSchema(Schema):
+    """Cron expression schema"""
+
+    objectType = fields.Constant("CronExpression", dump_to="__type", required=True)
+    value = fields.String(required=True)
+
+    @marshmallow.post_load
+    def make_cron_expression(self, data, **kwargs):
+        """Create cron expression based on data"""
+        return CronExpression(data["value"])
+
+
+class ScheduleIntervalSchema(OneOfSchema):
+    """
+    Schedule interval.
+
+    It supports the following types:
+
+    * TimeDelta
+    * RelativeDelta
+    * CronExpression
+    """
+    type_field = "__type"
+    type_schemas = {
+        "TimeDelta": TimeDeltaSchema,
+        "RelativeDelta": RelativeDeltaSchema,
+        "CronExpression": CronExpressionSchema,
+    }
+
+    def _dump(self, obj, update_fields=True, **kwargs):
+        if isinstance(obj, str):
+            obj = CronExpression(obj)
+
+        return super()._dump(obj, update_fields=update_fields, **kwargs)
+
+    def get_obj_type(self, obj):
+        """Select schema based on object type"""
+        if isinstance(obj, datetime.timedelta):
+            return "TimeDelta"
+        elif isinstance(obj, relativedelta.relativedelta):
+            return "RelativeDelta"
+        elif isinstance(obj, CronExpression):
+            return "CronExpression"
+        else:
+            raise Exception("Unknown object type: {}".format(obj.__class__.__name__))
+
+
+ColorField = partial(fields.String, validate=validate.Regexp("^#[a-fA-F0-9]{3,6}$"))

Review comment:
       Could you do less magic?
   https://github.com/apache/airflow/blob/75bd2f180e4afb591b08ee5d2cdb9b85737258b8/airflow/api_connexion/schemas/enum_schemas.py




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org