You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/18 23:40:13 UTC

[GitHub] [orc] williamhyun opened a new pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

williamhyun opened a new pull request #753:
URL: https://github.com/apache/orc/pull/753


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
     2. Use your PR title to summarize what this PR proposes instead of describing the problem.
     3. Make PR title and description complete because these will be the permanent commit log.
     4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
     5. If the PR is unfinished, use GitHub PR Draft feature.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140301


   @belugabehr . Your PR changes `compile` dependency to `provided` dependency. That's the regression which @williamhyun found. The ORC tools uber jar should have all required jars.
   
   Actually, it's my bad. I should have checked when I reviewed your PR, @belugabehr .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140356


   +1, LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144772


   BTW, no worries, @belugabehr . This is not released yet. It's lucky to find this earlier stage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #753:
URL: https://github.com/apache/orc/pull/753


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140301


   @belugabehr . Your PR changed `compile` dependency to `provided` dependency. That's the regression which @williamhyun found. The ORC tools uber jar should have all required jars.
   
   Actually, it's my bad. I should have checked when I reviewed your PR, @belugabehr .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882140722


   @belugabehr . Please check the parent pom here.
   - https://github.com/apache/orc/blob/main/java/pom.xml#L525
   - https://github.com/apache/orc/blob/main/java/pom.xml#L754


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] belugabehr commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144992


   Hey, ya, I'm quite familiar. I was just looking about to look that up regarding scope. I didn't not consider scope inheritance here. Again, sorry for the inconvenience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882138428


   Thank you so much, @williamhyun and @pgaref !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882134205


   CC: @belugabehr @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-886396609


   I backported #708 and this together to branch-1.7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144488


   @belugabehr . Do you know Maven POM inheritance? Here is the reference for you.
   - https://maven.apache.org/pom.html#inheritance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun edited a comment on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882144772


   BTW, no worries, @belugabehr . This is not released yet. It's lucky to find at this earlier stage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] belugabehr commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882139262


   I'm not sure I understand the change.
   
   > compile This is the default scope, used if none is specified.
   
   I do not expect this patch to have any affect on the build. Can you please explain?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] belugabehr commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882141827


   Hmm. I see. My apologies and thanks for the catch.  However, maybe I'm missing something obvious, but this PR simply adds the "compile" scope to something that previously had no scope (default: compile).  It does not change: provided => compile.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #753: ORC-851: Fix CNFE in ORC tools uber jar

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #753:
URL: https://github.com/apache/orc/pull/753#issuecomment-882145169


   Merged to main. Thank you, @williamhyun and all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org