You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "j143 (via GitHub)" <gi...@apache.org> on 2024/02/25 09:11:55 UTC
[PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
j143 opened a new pull request, #2002:
URL: https://github.com/apache/systemds/pull/2002
fix SLF4J: Failed to load class org.slf4j.impl.StaticLoggerBinder
---
Fixes SYSTEMDS-3673 / Fixes https://github.com/j143/systemds/issues/306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2002:
URL: https://github.com/apache/systemds/pull/2002#issuecomment-1978704338
The problem is:
```
Me:~/github/systemds/target/lib$ findjar slf4j.reload4j
(standard input): 0 Tue Feb 08 13:31:00 CET 2022 META-INF/maven/org.slf4j/slf4j-reload4j/
(standard input): 1153 Tue Feb 08 13:31:00 CET 2022 META-INF/maven/org.slf4j/slf4j-reload4j/pom.xml
(standard input): 62 Tue Feb 08 13:31:00 CET 2022 META-INF/maven/org.slf4j/slf4j-reload4j/pom.properties
slf4j-reload4j-1.7.36.jar
(standard input): 0 Mon Jan 08 17:55:00 CET 2024 org/slf4j/reload4j/
(standard input): 0 Mon Jan 08 17:55:00 CET 2024 META-INF/maven/org.slf4j/slf4j-reload4j/
(standard input): 5907 Mon Jan 08 17:55:00 CET 2024 org/slf4j/reload4j/Reload4jLoggerAdapter.class
(standard input): 2550 Mon Jan 08 17:55:00 CET 2024 org/slf4j/reload4j/Reload4jLoggerFactory.class
(standard input): 2928 Mon Jan 08 17:55:00 CET 2024 org/slf4j/reload4j/Reload4jMDCAdapter.class
(standard input): 1817 Mon Jan 08 17:55:00 CET 2024 org/slf4j/reload4j/Reload4jServiceProvider.class
(standard input): 2211 Mon Jan 08 17:55:00 CET 2024 META-INF/maven/org.slf4j/slf4j-reload4j/pom.xml
(standard input): 59 Mon Jan 08 17:55:00 CET 2024 META-INF/maven/org.slf4j/slf4j-reload4j/pom.properties
slf4j-reload4j-2.0.11.jar
```
We have two dependencies of slf4j
where one or more of our other dependencies adds the older version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2002:
URL: https://github.com/apache/systemds/pull/2002#issuecomment-1978725129
Thanks for the update @j143 , I have now merged it with a minor commit on top that fixes the double dependency of slf4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
Posted by "j143 (via GitHub)" <gi...@apache.org>.
j143 commented on PR #2002:
URL: https://github.com/apache/systemds/pull/2002#issuecomment-1962974576
Comments from @Baunsgaard , there seem to be an issue with logging when the `SYSTEMDS_ROOT` is not set.
```log
Me:~/Downloads/systemds-3.2.0-bin$ cat test.dml
x = rand(rows = 1000, cols = 10, min = -10, max = 10)
x = ceil(x)
y = rand(rows = 1000, cols = 1, min = 0, max = 1)
y = round(y)
bias = lm(X=x, y=y)
print(sum(bias))
Me:~/Downloads/systemds-3.2.0-bin$ ./bin/systemds test.dml
Calling the Direct Solver...
0.08330675008391338
SystemDS Statistics:
Total execution time: 0.053 sec.
Me:~/Downloads/systemds-3.2.0-bin$ unset SYSTEMDS_ROOT
Me:~/Downloads/systemds-3.2.0-bin$ ./bin/systemds test.dml
ERROR StatusLogger Reconfiguration failed: No configuration found for '55054057' at 'null' in 'null'
Calling the Direct Solver...
0.06721639156713015
SystemDS Statistics:
Total execution time:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2002:
URL: https://github.com/apache/systemds/pull/2002#issuecomment-1978695963
> Hi @mboehm7 / @Baunsgaard - perhaps we need to update here
>
> https://github.com/apache/systemds/blob/eb29b2d5488d503c97c6b5845a7fffee9a225eed/bin/systemds#L95-L114
>
> for `log4j2.configurationFile` instead of `log4j.configurationFile` or both (we shall check these)
I do not think this is the bug, but rather that we include to many dependency logging systems in our imported systems.
Also, I would prefer we do not change to the new logging file syntax(associated with the new versions).
I will try now to figure out if the newer versions works with our older logging files, otherwise we need to update all logging files, and call it a breaking dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #2002: [SYSTEMDS-3673] log4j and slf4j update to latest version
URL: https://github.com/apache/systemds/pull/2002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2002:
URL: https://github.com/apache/systemds/pull/2002#issuecomment-1962964097
Thanks for following up on this @j143 to move the release along - much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3673] log4j and slf4j update to latest version [systemds]
Posted by "j143 (via GitHub)" <gi...@apache.org>.
j143 commented on PR #2002:
URL: https://github.com/apache/systemds/pull/2002#issuecomment-1962982164
Hi @mboehm7 / @Baunsgaard - perhaps we need to update here
https://github.com/apache/systemds/blob/eb29b2d5488d503c97c6b5845a7fffee9a225eed/bin/systemds#L95-L114
for log4j2.configurationFile instead of log4j.configurationFile or both (we shall check these)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org