You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/08/04 21:15:04 UTC
[jira] [Commented] (KAFKA-2071) Replace Produce Request/Response
with their org.apache.kafka.common.requests equivalents
[ https://issues.apache.org/jira/browse/KAFKA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654185#comment-14654185 ]
ASF GitHub Bot commented on KAFKA-2071:
---------------------------------------
GitHub user dajac opened a pull request:
https://github.com/apache/kafka/pull/110
KAFKA-2071: Replace Producer Request/Response with their org.apache.kafka.common.requests equivalents
This PR replaces all producer request/response with their common equivalents but doesn't touch old producer at all.
Some conversions are made in KafkaApis to convert Java type/record to their Scala equivalents. For instance, `TopicPartition` must be converted to `TopicAndPartition` when it is passed to the ReplicaManager and vice versa. I've decided to not touch internals right now as their are used by other parts which makes updating them difficult. I'd prefer to address internals in a separate JIRA once all requests and responses are updated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dajac/kafka KAFKA-2071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
----
commit 8e1ca3c817b768a399d5ea54d6360d6180e4c39a
Author: David Jacot <da...@swisscom.com>
Date: 2015-08-04T16:47:36Z
Replace Producer Request/Response with their org.apache.kafka.common.requests equivalents.
----
> Replace Produce Request/Response with their org.apache.kafka.common.requests equivalents
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-2071
> URL: https://issues.apache.org/jira/browse/KAFKA-2071
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Gwen Shapira
> Assignee: David Jacot
> Fix For: 0.8.3
>
>
> Replace Produce Request/Response with their org.apache.kafka.common.requests equivalents
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)