[GitHub] [tez] mustafaiman commented on a change in pull request #75: TEZ-4213: Bound appContext executor capacity

[GitBox <gi...@apache.org>]

mustafaiman commented on a change in pull request #75:
URL: https://github.com/apache/tez/pull/75#discussion_r464578666



##########
File path: tez-dag/src/test/java/org/apache/tez/dag/app/dag/TestRootInputInitializerManager.java
##########
@@ -66,8 +69,11 @@
 
   @Before
   public void setUp() throws Exception {
-    ExecutorService rawExecutor = Executors.newCachedThreadPool(new ThreadFactoryBuilder()
-            .setDaemon(true).setNameFormat("Test App Shared Pool - " + "#%d").build());
+    Configuration conf = new Configuration(true);
+    ExecutorService rawExecutor =

Review comment:
       This is not the way to test the proposed changes here. Test overrides the behavior that we want to test. So it passes regardless of the actual patch anyway.

##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -621,8 +621,9 @@ public synchronized void serviceInit(final Configuration conf) throws Exception
       }
     }
 
-    rawExecutor = Executors.newCachedThreadPool(new ThreadFactoryBuilder().setDaemon(true)
-        .setNameFormat("App Shared Pool - " + "#%d").build());
+    Executors.newFixedThreadPool(conf.getInt(TezConfiguration.TEZ_AM_DAG_APPCONTEXT_THREAD_COUNT_LIMIT,

Review comment:
       This thread pool is dangling. I think this was supposed to be assigned to `rawExecutor`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org