You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Daniel Quinlan <qu...@pathname.com> on 2005/02/16 19:26:22 UTC

Re: [Bug 4124] New: New spamassassin script doesn't work due to tainting

Sidney Markowitz <si...@sidney.com> writes:

> Malte, the current makefile is broken for Windows in one place.
> 
> Line 1152 of Makefile.PL has
> 
> ifeq "$(INSTALLDIRS)" "site"
> INSTALLSCRIPTREALLY = $(INSTALLSITEBIN)
> else
> INSTALLSCRIPTREALLY = $(INSTALLSCRIPT)
> endif
> 
> In Windows we use nmake instead of GNU make, which has different
> conditional syntax:
> 
> !IF "$(INSTALLDIRS)" == "site"
> INSTALLSCRIPTREALLY = $(INSTALLSITEBIN)
> !ELSE
> INSTALLSCRIPTREALLY = $(INSTALLSCRIPT)
> !ENDIF

We support nmake?

Anyway, I added those lines.  Is there a way to conditionalize that
without ifeq or !if ?
 
Daniel

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/

Re: [Bug 4124] New: New spamassassin script doesn't work due to tainting

Posted by "Malte S. Stretz" <ms...@gmx.net>.
On Wednesday 16 February 2005 19:26 CET Daniel Quinlan wrote:
> Sidney Markowitz <si...@sidney.com> writes:
> > Malte, the current makefile is broken for Windows in one place.
> >
> > Line 1152 of Makefile.PL has
> >
> > ifeq "$(INSTALLDIRS)" "site"
> > INSTALLSCRIPTREALLY = $(INSTALLSITEBIN)
> > else
> > INSTALLSCRIPTREALLY = $(INSTALLSCRIPT)
> > endif
> >
> > In Windows we use nmake instead of GNU make, which has different
> > conditional syntax:
> >
> > !IF "$(INSTALLDIRS)" == "site"
> > INSTALLSCRIPTREALLY = $(INSTALLSITEBIN)
> > !ELSE
> > INSTALLSCRIPTREALLY = $(INSTALLSCRIPT)
> > !ENDIF
>
> We support nmake?
>
> Anyway, I added those lines.  Is there a way to conditionalize that
> without ifeq or !if ?

Yeah, don't do it in the Makefile :)  I forgot to commit the fix I have 
here, will do so later on.

Cheers,
Malte

-- 
[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
      <http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
      <http://www.catb.org/~esr/faqs/smart-questions.html>

Re: [Bug 4124] New: New spamassassin script doesn't work due to tainting

Posted by Sidney Markowitz <si...@sidney.com>.
Daniel Quinlan wrote:
> We support nmake?

That's the Microsoft nmake, not to be confused with any other make
program of the same name. It's what is available on Windows. For
compatibility we have to put all the fancy logic in the perl of
Makefile.PL so the resulting makefile is written to a dumbed down common
denominator.

I'll test out Malte's fix when he checks it in.

 -- sidney