You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2017/03/13 18:30:36 UTC
Review Request 57565: Ambari should allow empty string for
hive.metastore.uris when running in embedded mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57565/
-----------------------------------------------------------
Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-20427
https://issues.apache.org/jira/browse/AMBARI-20427
Repository: ambari
Description
-------
Ambari UI prevents setting a value of null or empty string for hive.metastore.uris
This is a valid use-case for embedded mode.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 4e6b6c3
ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py ed4586c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 3d08867
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 45a8c07
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py fdc96db
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 856941f
Diff: https://reviews.apache.org/r/57565/diff/1/
Testing
-------
Verified on live cluster.
mvn clean test
Thanks,
Alejandro Fernandez
Re: Review Request 57565: Ambari should allow empty string for
hive.metastore.uris when running in embedded mode
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On March 13, 2017, 7:29 p.m., Madhuvanthi Radhakrishnan wrote:
> > Hi Alejandro,
> > Do we not want the UnknownConfiguration scenario at all?
Can you explain in more detail? If the user intends to use an external MetaStore and they forget to set a URI value then that's obviously a case we can't identify since we don't know their intent.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57565/#review168818
-----------------------------------------------------------
On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57565/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-20427
> https://issues.apache.org/jira/browse/AMBARI-20427
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari UI prevents setting a value of null or empty string for hive.metastore.uris
> This is a valid use-case for embedded mode.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 4e6b6c3
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py ed4586c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 3d08867
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 45a8c07
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py fdc96db
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 856941f
>
>
> Diff: https://reviews.apache.org/r/57565/diff/1/
>
>
> Testing
> -------
>
> Verified on live cluster.
>
> mvn clean test
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 57565: Ambari should allow empty string for
hive.metastore.uris when running in embedded mode
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On March 13, 2017, 7:29 p.m., Madhuvanthi Radhakrishnan wrote:
> > Hi Alejandro,
> > Do we not want the UnknownConfiguration scenario at all?
>
> Alejandro Fernandez wrote:
> Can you explain in more detail? If the user intends to use an external MetaStore and they forget to set a URI value then that's obviously a case we can't identify since we don't know their intent.
I meant that, in the current version, there is a check as is_empty(address). It is a Lazy failing for unknown configs. In the fixed version, "address is UnknownConfiguration, UnknownConfiguration will be returned." this check is removed.
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57565/#review168818
-----------------------------------------------------------
On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57565/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-20427
> https://issues.apache.org/jira/browse/AMBARI-20427
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari UI prevents setting a value of null or empty string for hive.metastore.uris
> This is a valid use-case for embedded mode.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 4e6b6c3
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py ed4586c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 3d08867
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 45a8c07
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py fdc96db
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 856941f
>
>
> Diff: https://reviews.apache.org/r/57565/diff/1/
>
>
> Testing
> -------
>
> Verified on live cluster.
>
> mvn clean test
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 57565: Ambari should allow empty string for
hive.metastore.uris when running in embedded mode
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On March 13, 2017, 7:29 p.m., Madhuvanthi Radhakrishnan wrote:
> > Hi Alejandro,
> > Do we not want the UnknownConfiguration scenario at all?
>
> Alejandro Fernandez wrote:
> Can you explain in more detail? If the user intends to use an external MetaStore and they forget to set a URI value then that's obviously a case we can't identify since we don't know their intent.
>
> Madhuvanthi Radhakrishnan wrote:
> I meant that, in the current version, there is a check as is_empty(address). It is a Lazy failing for unknown configs. In the fixed version, "address is UnknownConfiguration, UnknownConfiguration will be returned." this check is removed.
The callers all default to a value of "" for the URI related configs so there should be no cases where address is an instance of UnknownConfiguration.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57565/#review168818
-----------------------------------------------------------
On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57565/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-20427
> https://issues.apache.org/jira/browse/AMBARI-20427
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari UI prevents setting a value of null or empty string for hive.metastore.uris
> This is a valid use-case for embedded mode.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 4e6b6c3
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py ed4586c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 3d08867
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 45a8c07
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py fdc96db
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 856941f
>
>
> Diff: https://reviews.apache.org/r/57565/diff/1/
>
>
> Testing
> -------
>
> Verified on live cluster.
>
> mvn clean test
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 57565: Ambari should allow empty string for
hive.metastore.uris when running in embedded mode
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57565/#review168818
-----------------------------------------------------------
Hi Alejandro,
Do we not want the UnknownConfiguration scenario at all?
- Madhuvanthi Radhakrishnan
On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57565/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-20427
> https://issues.apache.org/jira/browse/AMBARI-20427
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari UI prevents setting a value of null or empty string for hive.metastore.uris
> This is a valid use-case for embedded mode.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 4e6b6c3
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py ed4586c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 3d08867
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 45a8c07
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py fdc96db
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 856941f
>
>
> Diff: https://reviews.apache.org/r/57565/diff/1/
>
>
> Testing
> -------
>
> Verified on live cluster.
>
> mvn clean test
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 57565: Ambari should allow empty string for
hive.metastore.uris when running in embedded mode
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57565/#review168923
-----------------------------------------------------------
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57565/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 6:30 p.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-20427
> https://issues.apache.org/jira/browse/AMBARI-20427
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari UI prevents setting a value of null or empty string for hive.metastore.uris
> This is a valid use-case for embedded mode.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 4e6b6c3
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py ed4586c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml 3d08867
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 45a8c07
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py fdc96db
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml 856941f
>
>
> Diff: https://reviews.apache.org/r/57565/diff/1/
>
>
> Testing
> -------
>
> Verified on live cluster.
>
> mvn clean test
>
>
> Thanks,
>
> Alejandro Fernandez
>
>