You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/20 21:49:56 UTC

[GitHub] [ozone] DaveTeng0 opened a new pull request, #3767: Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method

DaveTeng0 opened a new pull request, #3767:
URL: https://github.com/apache/ozone/pull/3767

   ## What changes were proposed in this pull request?
   The way [this is](https://github.com/apache/ozone/pull/3614/files#diff-4e1ce03634e167877ec3c4d055a744b753d087ef7d9a3ed842f9936ef519aa71R925) written the method echoRPC should only run for older clients, but older clients do not have the echo rpc.
   
   Thus, we need to remove POST_PROCESSOR from OzoneManagerRequestHandler's echoRPC method.
   Also, remove echoRPC method from going through RATIS for now.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-7243
   
   ## How was this patch tested?
   Freon robot tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on a diff in pull request #3767: HDDS-7243. Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method

Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3767:
URL: https://github.com/apache/ozone/pull/3767#discussion_r978173184


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -910,16 +909,4 @@ default CancelPrepareResponse cancelOzoneManagerPrepare() throws IOException {
     return CancelPrepareResponse.newBuilder().build();
   }
 
-  /**
-   * Send RPC request with or without payload to OM

Review Comment:
   Why did we need to drop this from the OM Protocol?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] DaveTeng0 commented on pull request #3767: HDDS-7243. Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method

Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on PR #3767:
URL: https://github.com/apache/ozone/pull/3767#issuecomment-1298042434

   > @DaveTeng0 any update to this one?
   
   Yes! This is still working in progress! I was deviated to other thing, and I'll try to get back to this maybe after a week or two!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] DaveTeng0 closed pull request #3767: HDDS-7243. Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method

Posted by GitBox <gi...@apache.org>.
DaveTeng0 closed pull request #3767: HDDS-7243. Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method
URL: https://github.com/apache/ozone/pull/3767


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] DaveTeng0 commented on pull request #3767: Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method

Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on PR #3767:
URL: https://github.com/apache/ozone/pull/3767#issuecomment-1252951147

   cc. @kerneltime @errose28 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #3767: HDDS-7243. Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3767:
URL: https://github.com/apache/ozone/pull/3767#issuecomment-1297364133

   @DaveTeng0 any update to this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] DaveTeng0 commented on pull request #3767: HDDS-7243. Remove POST_PROCESSOR from OzoneManagerRequestHandler echoRPC method

Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on PR #3767:
URL: https://github.com/apache/ozone/pull/3767#issuecomment-1340189175

   The updated PR is in https://github.com/apache/ozone/pull/4051
   Closing this one!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org