You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/19 04:06:57 UTC
[GitHub] [pulsar] zengguan opened a new pull request, #17175: [fix][proxy] fix producer info logging fails when proxyLogLevel > 0
zengguan opened a new pull request, #17175:
URL: https://github.com/apache/pulsar/pull/17175
Fixes #17171
### Motivation
When field 'producer_name' is not set, producer info logging correctly
### Modifications
Set empty string producer_name when field 'producer_name' is not set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zengguan commented on pull request #17175: [fix][proxy] fix producer info logging fails when proxyLogLevel > 0
Posted by GitBox <gi...@apache.org>.
zengguan commented on PR #17175:
URL: https://github.com/apache/pulsar/pull/17175#issuecomment-1231564398
@eolivelli @Anonymitaet @merlimat @Technoboy- PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zengguan commented on pull request #17175: [fix][proxy] fix producer info logging fails when proxyLogLevel > 0
Posted by GitBox <gi...@apache.org>.
zengguan commented on PR #17175:
URL: https://github.com/apache/pulsar/pull/17175#issuecomment-1221919373
> is this the only place where producer name could cause error when proxyLogLevel > 0? if not we better find and fix all of them at once
Yes. This is the only place that could cause error. Others have `hasProducerName` to avoid it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17175: [fix][proxy] fix producer info logging fails when proxyLogLevel > 0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17175:
URL: https://github.com/apache/pulsar/pull/17175#issuecomment-1220241159
@zengguan Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 merged pull request #17175: [fix][proxy] fix producer info logging fails when proxyLogLevel > 0
Posted by GitBox <gi...@apache.org>.
Jason918 merged PR #17175:
URL: https://github.com/apache/pulsar/pull/17175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #17175: [fix][proxy] fix producer info logging fails when proxyLogLevel > 0
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on PR #17175:
URL: https://github.com/apache/pulsar/pull/17175#issuecomment-1221826946
is this the only place where producer name could cause error when proxyLogLevel > 0? if not we better find and fix all of them at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zengguan commented on pull request #17175: [fix][proxy] fix producer info logging fails when proxyLogLevel > 0
Posted by GitBox <gi...@apache.org>.
zengguan commented on PR #17175:
URL: https://github.com/apache/pulsar/pull/17175#issuecomment-1220244657
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org