You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "k5342 (via GitHub)" <gi...@apache.org> on 2023/05/17 10:47:18 UTC
[GitHub] [ozone] k5342 opened a new pull request, #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
k5342 opened a new pull request, #4723:
URL: https://github.com/apache/ozone/pull/4723
## What changes were proposed in this pull request?
I've found a NullPointerException while replicating V1 containers in Ozone 1.3.0. V1 containers do not have the schemaVersion field in the .container file, so that's why the cause of the exception.
Forward compatibility for handling V1 container schema was discussed at HDDS-3859: https://github.com/apache/ozone/pull/1298/files#r476042841.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8637
## How was this patch tested?
will checked by CI triggers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] k5342 commented on pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "k5342 (via GitHub)" <gi...@apache.org>.
k5342 commented on PR #4723:
URL: https://github.com/apache/ozone/pull/4723#issuecomment-1551734394
I will close this patch related to HDDS-8637. I will move on to HDDS-8636. Thank you for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4723:
URL: https://github.com/apache/ozone/pull/4723#issuecomment-1554666676
Thanks @k5342 for the feedback. Sure, I'll post a PR and assign the bug to myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] k5342 commented on pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "k5342 (via GitHub)" <gi...@apache.org>.
k5342 commented on PR #4723:
URL: https://github.com/apache/ozone/pull/4723#issuecomment-1554645068
Hi @adoroszlai , we've backported your suggestion for HDDS-8636 to [our ozone-1.3 branch](https://github.com/pfnet/ozone/commits/pfn-ozone-1.3.990006) and applied it for testing, and we can confirm it solves our problem related to V1 container replication. Could you create the patch as a pull request, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] k5342 commented on pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "k5342 (via GitHub)" <gi...@apache.org>.
k5342 commented on PR #4723:
URL: https://github.com/apache/ozone/pull/4723#issuecomment-1551648668
Thank you for the prompt reply. I plan to implement a fallback routine for computing a checksum for V1 containers to pass the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] k5342 closed pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "k5342 (via GitHub)" <gi...@apache.org>.
k5342 closed pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
URL: https://github.com/apache/ozone/pull/4723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4723:
URL: https://github.com/apache/ozone/pull/4723#issuecomment-1551201756
Thanks @k5342 for reporting the problem and working on the fix. Please check [unit test failure](https://github.com/k5342/ozone/actions/runs/5002209731/jobs/8961877157#step:6:1321) in `TestContainerDataYaml.testCheckBackWardCompatibilityOfContainerFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4723:
URL: https://github.com/apache/ozone/pull/4723#issuecomment-1551695386
@k5342 what's your opinion about keeping `schemaVersion=null` in the container, but implementing a simple comparison function that considers `null` and `SCHEMA_V1` equals to avoid NPE?
https://github.com/adoroszlai/hadoop-ozone/blob/158f713310ddacbf8f7a3d02c112360632945841/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java#L439-L443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] k5342 commented on pull request #4723: HDDS-8637. Add a null check for KeyValueContainerData#setSchemaVersion
Posted by "k5342 (via GitHub)" <gi...@apache.org>.
k5342 commented on PR #4723:
URL: https://github.com/apache/ozone/pull/4723#issuecomment-1551725820
@adoroszlai Thank you for your pointer. Sounds good to me for keeping a null than remove a null.
My initial thought is to avoid `null` by overwriting it at the `setSchemaVersion` could fix the overall NPE related to the schema field, but actually it requires rewriting checksum computation, and the change was bigger than I expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org