You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/04/01 19:21:23 UTC
[Impala-ASF-CR] Try out larger yarn containers
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17201
Change subject: Try out larger yarn containers
......................................................................
Try out larger yarn containers
Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17201/1
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7062/
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Apr 2021 05:03:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7084/
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Apr 2021 21:57:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has removed a vote on this change.
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Removed Code-Review-2 by Joe McDonnell <jo...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] Try out larger yarn containers
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: Try out larger yarn containers
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8494/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 19:41:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Try out larger yarn containers
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: Try out larger yarn containers
......................................................................
Patch Set 1: Code-Review-2
Now that we know it helps, we can move forward with this. This needs a better commit message, so I'm voting to make that clear.
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 20:16:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
IMPALA-10503: Use larger yarn containers for dataload
This increases the 'yarn.app.mapreduce.am.resource.mb'
parameter to 2GB in yarn-site.xml. This reduces the
frequency of dataload hitting the container size limit
on the docker-based tests and seems likely to address
other problems related to the container size.
Testing:
- Ran docker-based tests
- Ran GVO successfully
- Ran a debug core job on a different machine configuration
Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Reviewed-on: http://gerrit.cloudera.org:8080/17201
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8134/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 22 May 2022 03:46:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7062/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 23:16:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Try out larger yarn containers
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: Try out larger yarn containers
......................................................................
Patch Set 1: Code-Review+1
It helped my builds and did not break the FE tests.
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 12:40:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8536/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 23:16:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7084/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Apr 2021 16:07:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 4: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 22 May 2022 19:58:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Try out larger yarn containers
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: Try out larger yarn containers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 19:57:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17201
to look at the new patch set (#2).
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
IMPALA-10503: Use larger yarn containers for dataload
This increases the 'yarn.app.mapreduce.am.resource.mb'
parameter to 2GB in yarn-site.xml. This reduces the
frequency of dataload hitting the container size limit
on the docker-based tests and seems likely to address
other problems related to the container size.
Testing:
- Ran docker-based tests
- Ran GVO successfully
- Ran a debug core job on a different machine configuration
Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17201/2
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 )
Change subject: IMPALA-10503: Use larger yarn containers for dataload
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06567ffc44fa378be7c8cf4008f138b47b68d931
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 22 May 2022 08:12:53 +0000
Gerrit-HasComments: No