You are viewing a plain text version of this content. The canonical link for it is here.
Posted to photark-dev@incubator.apache.org by "Subash Chaturanga (JIRA)" <ji...@apache.org> on 2010/12/15 12:09:01 UTC

[jira] Created: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Improve the album storage structure in photark (trunk) local jcr
----------------------------------------------------------------

                 Key: PHOTARK-66
                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
             Project: PhotArk
          Issue Type: Improvement
         Environment: Linux
            Reporter: Subash Chaturanga


Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Sriskandarajah Suhothayan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sriskandarajah Suhothayan updated PHOTARK-66:
---------------------------------------------

    Attachment: Edited_version_for_PhotArk-66.patch

I have made some changes to Update3 patch using 
@reference and @Init 
Please check whether its working with remote Albums

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, changedJCRStructureUpdate_3.patch, Edited_version_for_PhotArk-66.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Subash Chaturanga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subash Chaturanga updated PHOTARK-66:
-------------------------------------

    Attachment: changedJCRStructureUpdate_1.patch

A new JCRAlbumAggregator class added to photark-jcr and build successfully. Please try this patch and inform what need to be improved or any pros or cons of this patch. 

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Sriskandarajah Suhothayan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983268#action_12983268 ] 

Sriskandarajah Suhothayan commented on PHOTARK-66:
--------------------------------------------------

I tested the patch Update-4.
I found that the gallery is still fetching the albums from the JCR root and not from /albums/local/
Please do the change for all JCR album accesses to fetch and store local albums from /albums/local/ 

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, changedJCRStructureUpdate_3.patch, changedJCRStructureUpdate_4.patch, Edited_version_for_PhotArk-66.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Sriskandarajah Suhothayan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976907#action_12976907 ] 

Sriskandarajah Suhothayan commented on PHOTARK-66:
--------------------------------------------------

I was getting some errors when applied changedJCRStructure.patch
Some imports are not added, and there is also a dependency issue.
Please look in to these and upload again.


> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Subash Chaturanga (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982693#action_12982693 ] 

Subash Chaturanga commented on PHOTARK-66:
------------------------------------------

Yes.It is. There is no connection between those two classes. The class I newly added was org.apache.photark.jcr.services.JCRAlbumAggregator. Both classes implements the same Album interface. Actually, initially I tried to  implement my album aggregator  in org.apache.photark.services.album.AlbumAgregator class. But due to an interdependency issue, I moved the aggregator to photark-jcr package. That's what happened. There is no need to have both classes. Both are same. But as AlbumAgregator class was already there initially, i didn't wanted to remove it from my patch.  So as this is a suggestion for a new structure, I didn't even touch the old code, I just overloaded all the methods in JCRGalleryImpl and JCRAlbumImpl with the new functionality and commented at the beginning of each new method for easy recognition. 

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Sriskandarajah Suhothayan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sriskandarajah Suhothayan updated PHOTARK-66:
---------------------------------------------

    Attachment: Screenshot.png

When i applied the Update1 patch, though i was able to build it, there seems to be some issue when running the application.
When I logged in my admin panel looks like Screenshot.png and I'm also not getting any error logs.



> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Subash Chaturanga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subash Chaturanga updated PHOTARK-66:
-------------------------------------

    Attachment: changedJCRStructureUpdate_2.patch

Done. Fixed that issue. It was due to a problem in the initialization of the gallery. And deployed the war and works fine,  :-) . Please try this as inform any  pros and cons of this patch regarding the change of the structure of local jcr in photark trunk.

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Subash Chaturanga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subash Chaturanga updated PHOTARK-66:
-------------------------------------

    Attachment: changedJCRStructureUpdate_5.patch

This patch is tested in a clean tomcat and the new structure is working for local albums.

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, changedJCRStructureUpdate_3.patch, changedJCRStructureUpdate_4.patch, changedJCRStructureUpdate_5.patch, Edited_version_for_PhotArk-66.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Sriskandarajah Suhothayan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982683#action_12982683 ] 

Sriskandarajah Suhothayan commented on PHOTARK-66:
--------------------------------------------------

It builds and runs without any issues. 
But I found that org.apache.photark.jcr.services.JCRAlbumAggregator  has no connection with org.apache.photark.services.album.AlbumAgregator
though they have similar methods and functionality.
I believe it would be better if you can generalize JCRAlbumAggregator using AlbumAgregator.

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Subash Chaturanga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subash Chaturanga updated PHOTARK-66:
-------------------------------------

    Attachment: changedJCRStructureUpdate_3.patch

Done as said. Now JCRAlbumAggregator extends AlbumAgregator. 

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, changedJCRStructureUpdate_3.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Subash Chaturanga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subash Chaturanga updated PHOTARK-66:
-------------------------------------

    Attachment: changedJCRStructureUpdate_4.patch

This patch is stores albums under /albums node as Suhothayan suggested.

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch, changedJCRStructureUpdate_1.patch, changedJCRStructureUpdate_2.patch, changedJCRStructureUpdate_3.patch, changedJCRStructureUpdate_4.patch, Edited_version_for_PhotArk-66.patch, Screenshot.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PHOTARK-66) Improve the album storage structure in photark (trunk) local jcr

Posted by "Subash Chaturanga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PHOTARK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subash Chaturanga updated PHOTARK-66:
-------------------------------------

    Attachment: changedJCRStructure.patch

In this patch I have changed all methods of JCRGalleryImpl and JCRAlbumImpl amd changed the AlbumAggregator class  so that they adhere to the new album structure where we insert albums of local and remote separately. For instance /local/..all local child albums and /remote/flicker/..  and /remote/picasa/...  . Actually in this case I have put a comment on all methods I have changed saying "Adhered to new structure" . Because I didn't remove any existing method. I just added overloaded method for each  JCRGalleryImpl and JCRAlbumImpl class. So that when any one try the patch it wont give any build failures as the UI already calling to previous model.

> Improve the album storage structure in photark (trunk) local jcr
> ----------------------------------------------------------------
>
>                 Key: PHOTARK-66
>                 URL: https://issues.apache.org/jira/browse/PHOTARK-66
>             Project: PhotArk
>          Issue Type: Improvement
>         Environment: Linux
>            Reporter: Subash Chaturanga
>         Attachments: changedJCRStructure.patch
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Currently in photark trunk, all albums are directly put under the root of local jcr regardless of the album type. Currently photark has basically two main album types, local and remote (flicker and picasa). So If the local jcr structure is much more organized in trunk such that it stores each album type under the relevant category. Hence  in future when some more other album types introduces it won't be too complex in the jcr level also. And it is efficient and fast, when we do jcr operations where we don't need to go through the whole album list each time, when we want to acquire all albums of one particular type.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.