You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "MyLoveZhou (via GitHub)" <gi...@apache.org> on 2023/08/21 05:50:04 UTC
[GitHub] [dolphinscheduler] MyLoveZhou opened a new pull request, #14775: fix issues #14753
MyLoveZhou opened a new pull request, #14775:
URL: https://github.com/apache/dolphinscheduler/pull/14775
## Purpose of the pull request
Solve the problem that when there is only one task left in the workflow, delete the task through Task Definition, resulting in the problem that the workflow cannot be deleted #14753
## Brief change log
Add logic to delete the relationship between workflow and task in `TaskDefinitionServiceImpl`.
## Verify this pull request
This pull request is already covered by existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix issues #14753 [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14775:
URL: https://github.com/apache/dolphinscheduler/pull/14775#issuecomment-1891128690
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #14775: fix issues #14753
Posted by "caishunfeng (via GitHub)" <gi...@apache.org>.
caishunfeng commented on PR #14775:
URL: https://github.com/apache/dolphinscheduler/pull/14775#issuecomment-1696882808
Hi @MyLoveZhou please correct this pr title, see https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix issues #14753 [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #14775: fix issues #14753
URL: https://github.com/apache/dolphinscheduler/pull/14775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix issues #14753 [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14775:
URL: https://github.com/apache/dolphinscheduler/pull/14775#issuecomment-1880243158
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #14775: fix issues #14753
Posted by "caishunfeng (via GitHub)" <gi...@apache.org>.
caishunfeng commented on code in PR #14775:
URL: https://github.com/apache/dolphinscheduler/pull/14775#discussion_r1308304278
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -504,6 +505,18 @@ public void deleteTaskDefinitionByCode(User loginUser, long taskCode) {
List<ProcessTaskRelation> relationList = processTaskRelations.stream()
.filter(r -> r.getPostTaskCode() != taskCode).collect(Collectors.toList());
updateDag(loginUser, processDefinitionCode, relationList, Lists.newArrayList());
+ /**
+ * if relationList is empty,The process_task_relation corresponding to this task will not be deleted,
+ * which will cause the task to be deleted in the task definition panel, but the workflow cannot be deleted.
+ */
+ //delete process_task_relation
+ if (relationList.size()==0){
+ LambdaQueryWrapper<ProcessTaskRelation> wrapper = new LambdaQueryWrapper<>();
Review Comment:
It's better to use sql instead of wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org