You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Laszlo Kishalmi <la...@gmail.com> on 2018/09/30 06:33:46 UTC
Pull Request review before NetBeans 10!
Dear all,
There are several PR-s out there, please review and merge everything
safely can be made!
We are about to branch for release 10 tomorrow.
I specially ask for help in combing and testing three of our windows
launcher related ones:
1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
<https://github.com/apache/incubator-netbeans/pull/883>
2. [NETBEANS-1157] resolved problem with java version higher 9 and the
n… <https://github.com/apache/incubator-netbeans/pull/734>
I do not have Windows around me to test these out.
Laszlo Kishalmi
Volunteer Release Manager of NetBeans 10
Re: Pull Request review before NetBeans 10!
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Here it is:
https://cwiki.apache.org/confluence/display/NETBEANS/10vc1
Gj
On Wed, Oct 3, 2018 at 5:34 AM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> We need to put up a 10vc1 Wiki where we list all issues we identify in
> 10vc1 so we can track those and decide what to do with them.
>
> Gj
>
> On Wednesday, October 3, 2018, Eirik Bakke <eb...@ultorg.com> wrote:
>
>> I just tried 10vc1 and can confirm that NETBEANS-1308 (Windows launcher
>> fails to suppress console) is still present.
>>
>> -- Eirik
>>
>> -----Original Message-----
>> From: Eirik Bakke <eb...@ultorg.com>
>> Sent: Sunday, September 30, 2018 9:09 PM
>> To: dev@netbeans.incubator.apache.org
>> Subject: RE: Pull Request review before NetBeans 10!
>>
>> Beware that the Windows launcher seems to have a bug, where the console
>> is not suppressed when the EXE file is launched from a shortcut or from the
>> Windows explorer. That was two weeks ago--I reported this as
>> https://issues.apache.org/jira/browse/NETBEANS-1308 . For anyone who
>> tries the latest launcher again, could you see if you still observe this
>> problem?
>>
>> For anyone who tests "[NETBEANS-1227] Mark Windows launchers as
>> DPI-aware", also feel free to test
>> https://github.com/apache/incubator-netbeans/pull/859 , which introduces
>> HiDPI icons in the window system ("X" buttons in tabs etc.). That one
>> should be ready to merge, if no one objects to the API change (add a new
>> public abstract class VectorIcon to org.openide.util.ui Utilities API, for
>> use by other modules that want to provide custom-painted HiDPI icons).
>>
>> -- Eirik
>>
>> -----Original Message-----
>> From: Laszlo Kishalmi <la...@gmail.com>
>> Sent: Sunday, September 30, 2018 2:34 AM
>> To: dev@netbeans.incubator.apache.org
>> Subject: Pull Request review before NetBeans 10!
>>
>> Dear all,
>>
>> There are several PR-s out there, please review and merge everything
>> safely can be made!
>>
>> We are about to branch for release 10 tomorrow.
>>
>> I specially ask for help in combing and testing three of our windows
>> launcher related ones:
>>
>> 1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
>> <https://github.com/apache/incubator-netbeans/pull/883>
>> 2. [NETBEANS-1157] resolved problem with java version higher 9 and the
>> n… <https://github.com/apache/incubator-netbeans/pull/734>
>>
>> I do not have Windows around me to test these out.
>>
>>
>> Laszlo Kishalmi
>>
>> Volunteer Release Manager of NetBeans 10
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
Re: Pull Request review before NetBeans 10!
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
We need to put up a 10vc1 Wiki where we list all issues we identify in
10vc1 so we can track those and decide what to do with them.
Gj
On Wednesday, October 3, 2018, Eirik Bakke <eb...@ultorg.com> wrote:
> I just tried 10vc1 and can confirm that NETBEANS-1308 (Windows launcher
> fails to suppress console) is still present.
>
> -- Eirik
>
> -----Original Message-----
> From: Eirik Bakke <eb...@ultorg.com>
> Sent: Sunday, September 30, 2018 9:09 PM
> To: dev@netbeans.incubator.apache.org
> Subject: RE: Pull Request review before NetBeans 10!
>
> Beware that the Windows launcher seems to have a bug, where the console is
> not suppressed when the EXE file is launched from a shortcut or from the
> Windows explorer. That was two weeks ago--I reported this as
> https://issues.apache.org/jira/browse/NETBEANS-1308 . For anyone who
> tries the latest launcher again, could you see if you still observe this
> problem?
>
> For anyone who tests "[NETBEANS-1227] Mark Windows launchers as
> DPI-aware", also feel free to test https://github.com/apache/
> incubator-netbeans/pull/859 , which introduces HiDPI icons in the window
> system ("X" buttons in tabs etc.). That one should be ready to merge, if no
> one objects to the API change (add a new public abstract class VectorIcon
> to org.openide.util.ui Utilities API, for use by other modules that want to
> provide custom-painted HiDPI icons).
>
> -- Eirik
>
> -----Original Message-----
> From: Laszlo Kishalmi <la...@gmail.com>
> Sent: Sunday, September 30, 2018 2:34 AM
> To: dev@netbeans.incubator.apache.org
> Subject: Pull Request review before NetBeans 10!
>
> Dear all,
>
> There are several PR-s out there, please review and merge everything
> safely can be made!
>
> We are about to branch for release 10 tomorrow.
>
> I specially ask for help in combing and testing three of our windows
> launcher related ones:
>
> 1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
> <https://github.com/apache/incubator-netbeans/pull/883>
> 2. [NETBEANS-1157] resolved problem with java version higher 9 and the
> n… <https://github.com/apache/incubator-netbeans/pull/734>
>
> I do not have Windows around me to test these out.
>
>
> Laszlo Kishalmi
>
> Volunteer Release Manager of NetBeans 10
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
RE: Pull Request review before NetBeans 10!
Posted by Eirik Bakke <eb...@ultorg.com>.
I just tried 10vc1 and can confirm that NETBEANS-1308 (Windows launcher fails to suppress console) is still present.
-- Eirik
-----Original Message-----
From: Eirik Bakke <eb...@ultorg.com>
Sent: Sunday, September 30, 2018 9:09 PM
To: dev@netbeans.incubator.apache.org
Subject: RE: Pull Request review before NetBeans 10!
Beware that the Windows launcher seems to have a bug, where the console is not suppressed when the EXE file is launched from a shortcut or from the Windows explorer. That was two weeks ago--I reported this as https://issues.apache.org/jira/browse/NETBEANS-1308 . For anyone who tries the latest launcher again, could you see if you still observe this problem?
For anyone who tests "[NETBEANS-1227] Mark Windows launchers as DPI-aware", also feel free to test https://github.com/apache/incubator-netbeans/pull/859 , which introduces HiDPI icons in the window system ("X" buttons in tabs etc.). That one should be ready to merge, if no one objects to the API change (add a new public abstract class VectorIcon to org.openide.util.ui Utilities API, for use by other modules that want to provide custom-painted HiDPI icons).
-- Eirik
-----Original Message-----
From: Laszlo Kishalmi <la...@gmail.com>
Sent: Sunday, September 30, 2018 2:34 AM
To: dev@netbeans.incubator.apache.org
Subject: Pull Request review before NetBeans 10!
Dear all,
There are several PR-s out there, please review and merge everything safely can be made!
We are about to branch for release 10 tomorrow.
I specially ask for help in combing and testing three of our windows launcher related ones:
1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
<https://github.com/apache/incubator-netbeans/pull/883>
2. [NETBEANS-1157] resolved problem with java version higher 9 and the
n… <https://github.com/apache/incubator-netbeans/pull/734>
I do not have Windows around me to test these out.
Laszlo Kishalmi
Volunteer Release Manager of NetBeans 10
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: Pull Request review before NetBeans 10!
Posted by Eirik Bakke <eb...@ultorg.com>.
Beware that the Windows launcher seems to have a bug, where the console is not suppressed when the EXE file is launched from a shortcut or from the Windows explorer. That was two weeks ago--I reported this as https://issues.apache.org/jira/browse/NETBEANS-1308 . For anyone who tries the latest launcher again, could you see if you still observe this problem?
For anyone who tests "[NETBEANS-1227] Mark Windows launchers as DPI-aware", also feel free to test https://github.com/apache/incubator-netbeans/pull/859 , which introduces HiDPI icons in the window system ("X" buttons in tabs etc.). That one should be ready to merge, if no one objects to the API change (add a new public abstract class VectorIcon to org.openide.util.ui Utilities API, for use by other modules that want to provide custom-painted HiDPI icons).
-- Eirik
-----Original Message-----
From: Laszlo Kishalmi <la...@gmail.com>
Sent: Sunday, September 30, 2018 2:34 AM
To: dev@netbeans.incubator.apache.org
Subject: Pull Request review before NetBeans 10!
Dear all,
There are several PR-s out there, please review and merge everything safely can be made!
We are about to branch for release 10 tomorrow.
I specially ask for help in combing and testing three of our windows launcher related ones:
1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
<https://github.com/apache/incubator-netbeans/pull/883>
2. [NETBEANS-1157] resolved problem with java version higher 9 and the
n… <https://github.com/apache/incubator-netbeans/pull/734>
I do not have Windows around me to test these out.
Laszlo Kishalmi
Volunteer Release Manager of NetBeans 10
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Pull Request review before NetBeans 10!
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Great.
And if someone (speak up soon, if so) objects, we can then remove the
cluster. No harm done.
Gj
On Sunday, September 30, 2018, Sven Reimers <sv...@gmail.com> wrote:
> Ok. Sounds good enough for me..
>
> Will start merging soon.
>
> Once I have some tests working I will add test execution to the matrix at
> travis.
>
> -Sven
>
> Geertjan Wielenga <ge...@googlemail.com.invalid> schrieb am
> So., 30. Sep. 2018, 13:14:
>
> > From me, no objections. You put in a lot of work around the Groovy
> cluster,
> > took ownership of it, know what you’re doing, and got everything done in
> > time, so I would say go ahead — and in a worst case scenario we can
> always
> > remove the groovy cluster if needed, i.e., if there turn out to be big
> > blockers of some kind, plus it’s a small cluster that doesn’t impact
> > anything else.
> >
> > Just my 2c.
> >
> > Gj
> >
> >
> > On Sunday, September 30, 2018, Sven Reimers <sv...@gmail.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > any objections here merging the groovy related PRs?
> > >
> > > (seems we have intermittent build failures due to launchers..zip)
> > >
> > > Thx
> > >
> > > -Sven
> > >
> > > Geertjan Wielenga <ge...@googlemail.com.invalid> schrieb
> am
> > > So., 30. Sep. 2018, 10:12:
> > >
> > > > Great.
> > > >
> > > > So the plan is to create a release10 branch and to put together the
> > first
> > > > voting candidate and that that voting candidate will then be used by
> > the
> > > > NetCAT community (and anyone else) to kick its tires and identify any
> > > > problems. Should there be no problems at all, we can go straight to
> the
> > > > PPMC vote thread on the dev mailing list, followed by the IPMC vote
> > > thread,
> > > > following this schedule:
> > > > https://cwiki.apache.org/confluence/display/NETBEANS/
> > > NetCAT+10.0+Schedule
> > > >
> > > > Thanks,
> > > >
> > > > Gj
> > > >
> > > >
> > > > On Sun, Sep 30, 2018 at 8:33 AM Laszlo Kishalmi <
> > > laszlo.kishalmi@gmail.com
> > > > >
> > > > wrote:
> > > >
> > > > > Dear all,
> > > > >
> > > > > There are several PR-s out there, please review and merge
> everything
> > > > > safely can be made!
> > > > >
> > > > > We are about to branch for release 10 tomorrow.
> > > > >
> > > > > I specially ask for help in combing and testing three of our
> windows
> > > > > launcher related ones:
> > > > >
> > > > > 1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
> > > > > <https://github.com/apache/incubator-netbeans/pull/883>
> > > > > 2. [NETBEANS-1157] resolved problem with java version higher 9 and
> > the
> > > > > n… <https://github.com/apache/incubator-netbeans/pull/734>
> > > > >
> > > > > I do not have Windows around me to test these out.
> > > > >
> > > > >
> > > > > Laszlo Kishalmi
> > > > >
> > > > > Volunteer Release Manager of NetBeans 10
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: Pull Request review before NetBeans 10!
Posted by Sven Reimers <sv...@gmail.com>.
Ok. Sounds good enough for me..
Will start merging soon.
Once I have some tests working I will add test execution to the matrix at
travis.
-Sven
Geertjan Wielenga <ge...@googlemail.com.invalid> schrieb am
So., 30. Sep. 2018, 13:14:
> From me, no objections. You put in a lot of work around the Groovy cluster,
> took ownership of it, know what you’re doing, and got everything done in
> time, so I would say go ahead — and in a worst case scenario we can always
> remove the groovy cluster if needed, i.e., if there turn out to be big
> blockers of some kind, plus it’s a small cluster that doesn’t impact
> anything else.
>
> Just my 2c.
>
> Gj
>
>
> On Sunday, September 30, 2018, Sven Reimers <sv...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > any objections here merging the groovy related PRs?
> >
> > (seems we have intermittent build failures due to launchers..zip)
> >
> > Thx
> >
> > -Sven
> >
> > Geertjan Wielenga <ge...@googlemail.com.invalid> schrieb am
> > So., 30. Sep. 2018, 10:12:
> >
> > > Great.
> > >
> > > So the plan is to create a release10 branch and to put together the
> first
> > > voting candidate and that that voting candidate will then be used by
> the
> > > NetCAT community (and anyone else) to kick its tires and identify any
> > > problems. Should there be no problems at all, we can go straight to the
> > > PPMC vote thread on the dev mailing list, followed by the IPMC vote
> > thread,
> > > following this schedule:
> > > https://cwiki.apache.org/confluence/display/NETBEANS/
> > NetCAT+10.0+Schedule
> > >
> > > Thanks,
> > >
> > > Gj
> > >
> > >
> > > On Sun, Sep 30, 2018 at 8:33 AM Laszlo Kishalmi <
> > laszlo.kishalmi@gmail.com
> > > >
> > > wrote:
> > >
> > > > Dear all,
> > > >
> > > > There are several PR-s out there, please review and merge everything
> > > > safely can be made!
> > > >
> > > > We are about to branch for release 10 tomorrow.
> > > >
> > > > I specially ask for help in combing and testing three of our windows
> > > > launcher related ones:
> > > >
> > > > 1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
> > > > <https://github.com/apache/incubator-netbeans/pull/883>
> > > > 2. [NETBEANS-1157] resolved problem with java version higher 9 and
> the
> > > > n… <https://github.com/apache/incubator-netbeans/pull/734>
> > > >
> > > > I do not have Windows around me to test these out.
> > > >
> > > >
> > > > Laszlo Kishalmi
> > > >
> > > > Volunteer Release Manager of NetBeans 10
> > > >
> > > >
> > >
> >
>
Re: Pull Request review before NetBeans 10!
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
From me, no objections. You put in a lot of work around the Groovy cluster,
took ownership of it, know what you’re doing, and got everything done in
time, so I would say go ahead — and in a worst case scenario we can always
remove the groovy cluster if needed, i.e., if there turn out to be big
blockers of some kind, plus it’s a small cluster that doesn’t impact
anything else.
Just my 2c.
Gj
On Sunday, September 30, 2018, Sven Reimers <sv...@gmail.com> wrote:
> Hi all,
>
> any objections here merging the groovy related PRs?
>
> (seems we have intermittent build failures due to launchers..zip)
>
> Thx
>
> -Sven
>
> Geertjan Wielenga <ge...@googlemail.com.invalid> schrieb am
> So., 30. Sep. 2018, 10:12:
>
> > Great.
> >
> > So the plan is to create a release10 branch and to put together the first
> > voting candidate and that that voting candidate will then be used by the
> > NetCAT community (and anyone else) to kick its tires and identify any
> > problems. Should there be no problems at all, we can go straight to the
> > PPMC vote thread on the dev mailing list, followed by the IPMC vote
> thread,
> > following this schedule:
> > https://cwiki.apache.org/confluence/display/NETBEANS/
> NetCAT+10.0+Schedule
> >
> > Thanks,
> >
> > Gj
> >
> >
> > On Sun, Sep 30, 2018 at 8:33 AM Laszlo Kishalmi <
> laszlo.kishalmi@gmail.com
> > >
> > wrote:
> >
> > > Dear all,
> > >
> > > There are several PR-s out there, please review and merge everything
> > > safely can be made!
> > >
> > > We are about to branch for release 10 tomorrow.
> > >
> > > I specially ask for help in combing and testing three of our windows
> > > launcher related ones:
> > >
> > > 1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
> > > <https://github.com/apache/incubator-netbeans/pull/883>
> > > 2. [NETBEANS-1157] resolved problem with java version higher 9 and the
> > > n… <https://github.com/apache/incubator-netbeans/pull/734>
> > >
> > > I do not have Windows around me to test these out.
> > >
> > >
> > > Laszlo Kishalmi
> > >
> > > Volunteer Release Manager of NetBeans 10
> > >
> > >
> >
>
Re: Pull Request review before NetBeans 10!
Posted by Sven Reimers <sv...@gmail.com>.
Hi all,
any objections here merging the groovy related PRs?
(seems we have intermittent build failures due to launchers..zip)
Thx
-Sven
Geertjan Wielenga <ge...@googlemail.com.invalid> schrieb am
So., 30. Sep. 2018, 10:12:
> Great.
>
> So the plan is to create a release10 branch and to put together the first
> voting candidate and that that voting candidate will then be used by the
> NetCAT community (and anyone else) to kick its tires and identify any
> problems. Should there be no problems at all, we can go straight to the
> PPMC vote thread on the dev mailing list, followed by the IPMC vote thread,
> following this schedule:
> https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+10.0+Schedule
>
> Thanks,
>
> Gj
>
>
> On Sun, Sep 30, 2018 at 8:33 AM Laszlo Kishalmi <laszlo.kishalmi@gmail.com
> >
> wrote:
>
> > Dear all,
> >
> > There are several PR-s out there, please review and merge everything
> > safely can be made!
> >
> > We are about to branch for release 10 tomorrow.
> >
> > I specially ask for help in combing and testing three of our windows
> > launcher related ones:
> >
> > 1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
> > <https://github.com/apache/incubator-netbeans/pull/883>
> > 2. [NETBEANS-1157] resolved problem with java version higher 9 and the
> > n… <https://github.com/apache/incubator-netbeans/pull/734>
> >
> > I do not have Windows around me to test these out.
> >
> >
> > Laszlo Kishalmi
> >
> > Volunteer Release Manager of NetBeans 10
> >
> >
>
Re: Pull Request review before NetBeans 10!
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Great.
So the plan is to create a release10 branch and to put together the first
voting candidate and that that voting candidate will then be used by the
NetCAT community (and anyone else) to kick its tires and identify any
problems. Should there be no problems at all, we can go straight to the
PPMC vote thread on the dev mailing list, followed by the IPMC vote thread,
following this schedule:
https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+10.0+Schedule
Thanks,
Gj
On Sun, Sep 30, 2018 at 8:33 AM Laszlo Kishalmi <la...@gmail.com>
wrote:
> Dear all,
>
> There are several PR-s out there, please review and merge everything
> safely can be made!
>
> We are about to branch for release 10 tomorrow.
>
> I specially ask for help in combing and testing three of our windows
> launcher related ones:
>
> 1. [NETBEANS-1227] Mark Windows launchers as DPI-aware
> <https://github.com/apache/incubator-netbeans/pull/883>
> 2. [NETBEANS-1157] resolved problem with java version higher 9 and the
> n… <https://github.com/apache/incubator-netbeans/pull/734>
>
> I do not have Windows around me to test these out.
>
>
> Laszlo Kishalmi
>
> Volunteer Release Manager of NetBeans 10
>
>