You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "datalesniak (via GitHub)" <gi...@apache.org> on 2024/06/14 12:32:44 UTC
[PR] add sso support [superset]
datalesniak opened a new pull request, #29254:
URL: https://github.com/apache/superset/pull/29254
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] add sso support [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley closed pull request #29254: add sso support
URL: https://github.com/apache/superset/pull/29254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] add sso support [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #29254:
URL: https://github.com/apache/superset/pull/29254#issuecomment-2168286662
Hi there,
I'm assuming you didn't mean to open this PR, but if you did, please watch out for PII/credentials, and please fill out the rest of the PR template to let us know what your goal here is :)
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] add sso support [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #29254:
URL: https://github.com/apache/superset/pull/29254#discussion_r1640002285
##########
docker/docker-init.sh:
##########
@@ -37,7 +37,7 @@ Init Step ${1}/${STEP_CNT} [${2}] -- ${3}
EOF
}
-ADMIN_PASSWORD="admin"
+ADMIN_PASSWORD="datakimia2024"
Review Comment:
I'm not sure if you actually meant to open this PR, but you _probably_ didn't mean to commit this password. You might want to change it on your instance :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] add sso support [superset]
Posted by "datalesniak (via GitHub)" <gi...@apache.org>.
datalesniak commented on PR #29254:
URL: https://github.com/apache/superset/pull/29254#issuecomment-2168302612
Hi, this PR was made by mistake, Please ignore it.
thanks for your advice !
El vie, 14 jun 2024 a la(s) 12:36 p.m., Evan Rusackas (
***@***.***) escribió:
> Hi there,
>
> I'm assuming you didn't mean to open this PR, but if you did, please watch
> out for PII/credentials, and please fill out the rest of the PR template to
> let us know what your goal here is :)
>
> Thanks!
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/superset/pull/29254#issuecomment-2168286662>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BH24QXKBQNYJGJEO2F4LMHLZHMEWTAVCNFSM6AAAAABJKISTKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGI4DMNRWGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org