You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/24 18:17:39 UTC

[GitHub] [spark] ueshin commented on a diff in pull request #37642: [SPARK-40202][PYTHON][SQL] Allow a dictionary in SparkSession.config in PySpark

ueshin commented on code in PR #37642:
URL: https://github.com/apache/spark/pull/37642#discussion_r954135287


##########
python/pyspark/sql/session.py:
##########
@@ -202,6 +202,7 @@ def config(
             key: Optional[str] = None,
             value: Optional[Any] = None,
             conf: Optional[SparkConf] = None,
+            map: Optional[Dict[str, "OptionalPrimitiveType"]] = None,

Review Comment:
   nit: how about using keyword-only argument?
   
   ```py
               conf: Optional[SparkConf] = None,
               *,
               map: Optional[Dict[str, "OptionalPrimitiveType"]] = None,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org