You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by st...@apache.org on 2024/01/30 09:30:55 UTC

(doris) branch branch-2.0 updated: [fix](nereids)group by expr may be lost in EliminateGroupByConstant rule (#30517)

This is an automated email from the ASF dual-hosted git repository.

starocean999 pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.0 by this push:
     new 73a7634ec9a [fix](nereids)group by expr may be lost in EliminateGroupByConstant rule (#30517)
73a7634ec9a is described below

commit 73a7634ec9aed4956f324eca9525513743e5e970
Author: starocean999 <40...@users.noreply.github.com>
AuthorDate: Tue Jan 30 17:30:44 2024 +0800

    [fix](nereids)group by expr may be lost in EliminateGroupByConstant rule (#30517)
---
 .../apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java
index e7fa14e5cb2..e683153e9a2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateGroupByConstant.java
@@ -67,7 +67,7 @@ public class EliminateGroupByConstant extends OneRewriteRuleFactory {
                     lit = expression;
                 }
             }
-            if (slotGroupByExprs.isEmpty() && lit != null && aggregate.getAggregateFunctions().isEmpty()) {
+            if (slotGroupByExprs.isEmpty() && lit != null) {
                 slotGroupByExprs.add(lit);
             }
             return aggregate.withGroupByAndOutput(ImmutableList.copyOf(slotGroupByExprs), outputExprs);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org