You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/07 16:08:34 UTC

[GitHub] [incubator-eventmesh] tydhot opened a new pull request #424: [ISSUE #405]modify the doc

tydhot opened a new pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424


   #TBD


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] tydhot commented on pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
tydhot commented on pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#issuecomment-876978979


   @qqeasonchen done:)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#issuecomment-876943967


   @tydhot can you fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] tydhot commented on a change in pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r666187622



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -75,21 +75,7 @@ sh start.sh
 ```
 > 注：如果操作系统为Windows, 可能需要将文件分隔符换成\
 
-**2.3.3 配置build.gradle文件**
-
-通过修改dependencies，compile project 项来指定项目启动后加载的插件
-
-修改`eventmesh-starter`模块下面的`build.gradle`文件
-
-加载**RocketMQ**插件配置：
-
-```java
-dependencies {
-    compile project(":eventmesh-runtime"), project(":eventmesh-connector-rocketmq")
-}
-```
-
-**2.3.4 启动运行**
+**2.3.3 启动运行**

Review comment:
       I just follow this guide to start the event mesh yesterday. I just found that user don't need to change the build.gradle like what you said. And the start param should be set just before you run the main class. Set them first will be a little weird.And I can't compile this project in java 11 at first time. I think it should be mentioned in the  quick start guide.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#issuecomment-875739903


   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#424](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c9c9955) into [1.3.0](https://codecov.io/gh/apache/incubator-eventmesh/commit/c18adf774c5de2f77238c086adbdc7d128cb53c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c18adf7) will **increase** coverage by `3.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##             1.3.0    #424      +/-   ##
   ==========================================
   + Coverage     4.77%   8.39%   +3.62%     
   - Complexity     141     256     +115     
   ==========================================
     Files          227     227              
     Lines        10816   10816              
     Branches       929     929              
   ==========================================
   + Hits           516     908     +392     
   + Misses       10233    9834     -399     
   - Partials        67      74       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sh/common/protocol/http/body/BaseResponseBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvQmFzZVJlc3BvbnNlQm9keS5qYXZh) | `81.25% <0.00%> (+31.25%)` | :arrow_up: |
   | [...h/common/protocol/http/common/ProtocolVersion.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9Qcm90b2NvbFZlcnNpb24uamF2YQ==) | `35.00% <0.00%> (+35.00%)` | :arrow_up: |
   | [...ommon/protocol/http/header/BaseResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9CYXNlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `90.00% <0.00%> (+60.00%)` | :arrow_up: |
   | [...common/protocol/http/header/BaseRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9CYXNlUmVxdWVzdEhlYWRlci5qYXZh) | `64.28% <0.00%> (+64.28%)` | :arrow_up: |
   | [...protocol/http/header/client/RegResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvUmVnUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `65.78% <0.00%> (+65.78%)` | :arrow_up: |
   | [...otocol/http/header/client/UnRegResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvVW5SZWdSZXNwb25zZUhlYWRlci5qYXZh) | `65.78% <0.00%> (+65.78%)` | :arrow_up: |
   | [...ol/http/header/client/HeartbeatResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvSGVhcnRiZWF0UmVzcG9uc2VIZWFkZXIuamF2YQ==) | `65.78% <0.00%> (+65.78%)` | :arrow_up: |
   | [...ol/http/header/client/SubscribeResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvU3Vic2NyaWJlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `65.78% <0.00%> (+65.78%)` | :arrow_up: |
   | [.../http/header/client/UnSubscribeResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvVW5TdWJzY3JpYmVSZXNwb25zZUhlYWRlci5qYXZh) | `65.78% <0.00%> (+65.78%)` | :arrow_up: |
   | [.../protocol/http/header/client/RegRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvUmVnUmVxdWVzdEhlYWRlci5qYXZh) | `66.66% <0.00%> (+66.66%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c18adf7...c9c9955](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r666178226



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -75,21 +75,7 @@ sh start.sh
 ```
 > 注：如果操作系统为Windows, 可能需要将文件分隔符换成\
 
-**2.3.3 配置build.gradle文件**
-
-通过修改dependencies，compile project 项来指定项目启动后加载的插件
-
-修改`eventmesh-starter`模块下面的`build.gradle`文件
-
-加载**RocketMQ**插件配置：
-
-```java
-dependencies {
-    compile project(":eventmesh-runtime"), project(":eventmesh-connector-rocketmq")
-}
-```
-
-**2.3.4 启动运行**
+**2.3.3 启动运行**

Review comment:
       I think you may don't need to change this place, what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] tydhot commented on a change in pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r666221681



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -75,21 +75,7 @@ sh start.sh
 ```
 > 注：如果操作系统为Windows, 可能需要将文件分隔符换成\
 
-**2.3.3 配置build.gradle文件**
-
-通过修改dependencies，compile project 项来指定项目启动后加载的插件
-
-修改`eventmesh-starter`模块下面的`build.gradle`文件
-
-加载**RocketMQ**插件配置：
-
-```java
-dependencies {
-    compile project(":eventmesh-runtime"), project(":eventmesh-connector-rocketmq")
-}
-```
-
-**2.3.4 启动运行**
+**2.3.3 启动运行**

Review comment:
       oops, maybe I can resolve the conflict after that pr is merged. It would be a little challenge to avoid the conflict in single pr.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r666217862



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -75,21 +75,7 @@ sh start.sh
 ```
 > 注：如果操作系统为Windows, 可能需要将文件分隔符换成\
 
-**2.3.3 配置build.gradle文件**
-
-通过修改dependencies，compile project 项来指定项目启动后加载的插件
-
-修改`eventmesh-starter`模块下面的`build.gradle`文件
-
-加载**RocketMQ**插件配置：
-
-```java
-dependencies {
-    compile project(":eventmesh-runtime"), project(":eventmesh-connector-rocketmq")
-}
-```
-
-**2.3.4 启动运行**
+**2.3.3 启动运行**

Review comment:
       Yes, I mean you may don't need to remove the line 78 to 92, this may cause conflict with another pr :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] tydhot commented on a change in pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r665889931



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -65,17 +65,7 @@ sh start.sh
 
 > 注：插件模块遵循java spi机制，需要在对应模块中的/main/resources/META-INF/services 下配置相关接口与实现类的映射文件
 
-**2.3.2 配置VM启动参数**
-
-```java
--Dlog4j.configurationFile=eventmesh-runtime/conf/log4j2.xml
--Deventmesh.log.home=eventmesh-runtime/logs
--Deventmesh.home=eventmesh-runtime
--DconfPath=eventmesh-runtime/conf
-```
-> 注：如果操作系统为Windows, 可能需要将文件分隔符换成\
-
-**2.3.3 配置build.gradle文件**
+**2.3.2 配置build.gradle文件**

Review comment:
       yes, I got it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#issuecomment-876999104


   nice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r665824663



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -44,7 +44,7 @@ sh start.sh
 
 ### 2.1 依赖
 
-同上述步骤 1.1
+同上述步骤 1.1，但是只能在JDK 1.8下构建

Review comment:
       It seems that we have declared the JDK version as 1.8+ in the 1.1 section.

##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -65,17 +65,7 @@ sh start.sh
 
 > 注：插件模块遵循java spi机制，需要在对应模块中的/main/resources/META-INF/services 下配置相关接口与实现类的映射文件
 
-**2.3.2 配置VM启动参数**
-
-```java
--Dlog4j.configurationFile=eventmesh-runtime/conf/log4j2.xml
--Deventmesh.log.home=eventmesh-runtime/logs
--Deventmesh.home=eventmesh-runtime
--DconfPath=eventmesh-runtime/conf
-```
-> 注：如果操作系统为Windows, 可能需要将文件分隔符换成\
-
-**2.3.3 配置build.gradle文件**
+**2.3.2 配置build.gradle文件**

Review comment:
       The configuration process of plugin has changed, we no longer need to modify the `build.gradle` file and compile again, you can refer to #421.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#issuecomment-875739903


   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#424](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9fb3941) into [1.3.0](https://codecov.io/gh/apache/incubator-eventmesh/commit/c18adf774c5de2f77238c086adbdc7d128cb53c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c18adf7) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/424/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##             1.3.0    #424   +/-   ##
   =======================================
     Coverage     4.77%   4.77%           
     Complexity     141     141           
   =======================================
     Files          227     227           
     Lines        10816   10816           
     Branches       929     929           
   =======================================
     Hits           516     516           
     Misses       10233   10233           
     Partials        67      67           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c18adf7...9fb3941](https://codecov.io/gh/apache/incubator-eventmesh/pull/424?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r666234003



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -75,21 +75,7 @@ sh start.sh
 ```
 > 注：如果操作系统为Windows, 可能需要将文件分隔符换成\
 
-**2.3.3 配置build.gradle文件**
-
-通过修改dependencies，compile project 项来指定项目启动后加载的插件
-
-修改`eventmesh-starter`模块下面的`build.gradle`文件
-
-加载**RocketMQ**插件配置：
-
-```java
-dependencies {
-    compile project(":eventmesh-runtime"), project(":eventmesh-connector-rocketmq")
-}
-```
-
-**2.3.4 启动运行**
+**2.3.3 启动运行**

Review comment:
       hahah




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #424: [ISSUE #405]modify the doc

Posted by GitBox <gi...@apache.org>.
qqeasonchen merged pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org