[BUG] PROPPATCH delete (svn propdel) errors not returned

[Arwin <ar...@collab.net>]

Hi All,

I've filed Bug 53525 
<https://issues.apache.org/bugzilla/show_bug.cgi?id=53525> in the ASF 
Bugzilla.

<Description>

On failure to execute a PROPPATCH to remove a property, the error is not returned to the caller.

A comment in the code says:

<code snippet>

1044: /*
1045: ** Delete the property. Ignore errors -- the property is there, or
1046: ** we are deleting it for a second time.
1047: */
1048: /* ### but what about other errors? */
1049: (void) (*propdb->db_hooks->remove)(propdb->db, &name);

</code snippet>

In subversion, property deletions are subject to authorization, and hook script execution.

In the current state of things, regardless of the outcome of the PROPPATCH, the client receives a 2xx class response. I suggest the attached patch to fix this.


</Description>

Regards,
Arwin Arni

Re: [BUG] PROPPATCH delete (svn propdel) errors not returned

[Arwin Arni <ar...@collab.net>]

Hi All,

Can somebody please review this.

I would like to know if the current behavior would ever be changed.

Regards,
Arwin Arni


On 07/09/2012 06:11 PM, Arwin wrote:
> Hi All,
>
> I've filed Bug 53525 
> <https://issues.apache.org/bugzilla/show_bug.cgi?id=53525> in the ASF 
> Bugzilla.
>
> <Description>
> On failure to execute a PROPPATCH to remove a property, the error is not returned to the caller.
>
> A comment in the code says:
>
> <code snippet>
>
> 1044: /*
> 1045: ** Delete the property. Ignore errors -- the property is there, or
> 1046: ** we are deleting it for a second time.
> 1047: */
> 1048: /* ### but what about other errors? */
> 1049: (void) (*propdb->db_hooks->remove)(propdb->db, &name);
>
> </code snippet>
>
> In subversion, property deletions are subject to authorization, and hook script execution.
>
> In the current state of things, regardless of the outcome of the PROPPATCH, the client receives a 2xx class response. I suggest the attached patch to fix this.
>
> </Description>
>
> Regards,
> Arwin Arni