[GitHub] [qpid-dispatch] franz1981 commented on issue #508: DISPATCH-1342 Replaced mutex with spin lock on qd_message content

[GitBox <gi...@apache.org>]

franz1981 commented on issue #508: DISPATCH-1342 Replaced mutex with spin lock on qd_message content
URL: https://github.com/apache/qpid-dispatch/pull/508#issuecomment-505450597
 
 
   @astitcher Totally agree, that's why I haven't replaced the mutexes for any possible use case; there are some requirements that need to be satisfied in order to make this change effective (or feasable).
   We need to:
   
   - be sure no reentrancy is happening on the mutual exclusion zone (and it seems the case, looking the code)
   - be sure that the mutual exclusion zone is not held for too much time (to be defined) and none is blocked on it
   
   If both these requirements are met, only proper benchmarking and tests can tell us if the spin lock is the right answer here. I would stick to something that won't require OS arbitrations on the hot path anyway: OS is like burocrazy and I won't bother it when user-space matters can already solve things with a more predictable latencies 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org