You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Oliver Deakin (JIRA)" <ji...@apache.org> on 2006/06/28 17:51:29 UTC
[jira] Created: (HARMONY-695) [classlib] Remove two unnecessary
header files
[classlib] Remove two unnecessary header files
----------------------------------------------
Key: HARMONY-695
URL: http://issues.apache.org/jira/browse/HARMONY-695
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Oliver Deakin
Priority: Minor
native-src/shared/common/jcl.h and modules/luni/src/main/native/include/shared/hamony.h are identical, and both basically just do:
#define USING_VMI
#include "vmi.h"
This is pointless, since vmi.h is a shared header file (copied into deploy/include) at build time anyway. I propose that these two header files are removed, and files that include them are fixed up to include vmi.h instead.
I will attach a patch to remove the files shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-695) [classlib] Remove two unnecessary
header files
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-695?page=all ]
Mark Hindess reassigned HARMONY-695:
------------------------------------
Assign To: Mark Hindess
> [classlib] Remove two unnecessary header files
> ----------------------------------------------
>
> Key: HARMONY-695
> URL: http://issues.apache.org/jira/browse/HARMONY-695
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: cleanup.unnecessary.headers.diff, cleanup.unnecessary.headers.sh
>
> native-src/shared/common/jcl.h and modules/luni/src/main/native/include/shared/hamony.h are identical, and both basically just do:
> #define USING_VMI
> #include "vmi.h"
> This is pointless, since vmi.h is a shared header file (copied into deploy/include) at build time anyway. I propose that these two header files are removed, and files that include them are fixed up to include vmi.h instead.
> I will attach a patch to remove the files shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-695) [classlib] Remove two unnecessary
header files
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-695?page=all ]
Mark Hindess resolved HARMONY-695:
----------------------------------
Resolution: Fixed
Applied in r417829. Please check it is applied as expected.
> [classlib] Remove two unnecessary header files
> ----------------------------------------------
>
> Key: HARMONY-695
> URL: http://issues.apache.org/jira/browse/HARMONY-695
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: cleanup.unnecessary.headers.diff, cleanup.unnecessary.headers.sh
>
> native-src/shared/common/jcl.h and modules/luni/src/main/native/include/shared/hamony.h are identical, and both basically just do:
> #define USING_VMI
> #include "vmi.h"
> This is pointless, since vmi.h is a shared header file (copied into deploy/include) at build time anyway. I propose that these two header files are removed, and files that include them are fixed up to include vmi.h instead.
> I will attach a patch to remove the files shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-695) [classlib] Remove two unnecessary
header files
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-695?page=all ]
Mark Hindess closed HARMONY-695:
--------------------------------
Verified by Oliver.
> [classlib] Remove two unnecessary header files
> ----------------------------------------------
>
> Key: HARMONY-695
> URL: http://issues.apache.org/jira/browse/HARMONY-695
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: cleanup.unnecessary.headers.diff, cleanup.unnecessary.headers.sh
>
> native-src/shared/common/jcl.h and modules/luni/src/main/native/include/shared/hamony.h are identical, and both basically just do:
> #define USING_VMI
> #include "vmi.h"
> This is pointless, since vmi.h is a shared header file (copied into deploy/include) at build time anyway. I propose that these two header files are removed, and files that include them are fixed up to include vmi.h instead.
> I will attach a patch to remove the files shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-695) [classlib] Remove two unnecessary
header files
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-695?page=all ]
Oliver Deakin updated HARMONY-695:
----------------------------------
Attachment: cleanup.unnecessary.headers.sh
cleanup.unnecessary.headers.diff
cleanup.unnecessary.headers.sh removes the two header files that are no longer needed.
cleanup.unnecessary.headers.diff fixes up the files that used to include those headers.
The two patches can be applied in any order, as they touch disjoint sets of files. The patches should be applied to the root directory of a classlib/trunk checkout.
> [classlib] Remove two unnecessary header files
> ----------------------------------------------
>
> Key: HARMONY-695
> URL: http://issues.apache.org/jira/browse/HARMONY-695
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Priority: Minor
> Attachments: cleanup.unnecessary.headers.diff, cleanup.unnecessary.headers.sh
>
> native-src/shared/common/jcl.h and modules/luni/src/main/native/include/shared/hamony.h are identical, and both basically just do:
> #define USING_VMI
> #include "vmi.h"
> This is pointless, since vmi.h is a shared header file (copied into deploy/include) at build time anyway. I propose that these two header files are removed, and files that include them are fixed up to include vmi.h instead.
> I will attach a patch to remove the files shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-695) [classlib] Remove two unnecessary
header files
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-695?page=comments#action_12418284 ]
Oliver Deakin commented on HARMONY-695:
---------------------------------------
Looks good - thanks Mark.
> [classlib] Remove two unnecessary header files
> ----------------------------------------------
>
> Key: HARMONY-695
> URL: http://issues.apache.org/jira/browse/HARMONY-695
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Mark Hindess
> Priority: Minor
> Attachments: cleanup.unnecessary.headers.diff, cleanup.unnecessary.headers.sh
>
> native-src/shared/common/jcl.h and modules/luni/src/main/native/include/shared/hamony.h are identical, and both basically just do:
> #define USING_VMI
> #include "vmi.h"
> This is pointless, since vmi.h is a shared header file (copied into deploy/include) at build time anyway. I propose that these two header files are removed, and files that include them are fixed up to include vmi.h instead.
> I will attach a patch to remove the files shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira