You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/30 23:18:41 UTC

[GitHub] [beam] kw2542 commented on a change in pull request #15081: [BEAM-12503] Process Support for ExternalWorkerService

kw2542 commented on a change in pull request #15081:
URL: https://github.com/apache/beam/pull/15081#discussion_r661870261



##########
File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -79,13 +79,16 @@
 
   private static final String dockerContainerImageOption = "docker_container_image";
   private static final String externalServiceAddressOption = "external_service_address";
+  private static final String externalServiceExecutableOption = "external_service_executable";

Review comment:
       This makes sense, the runner should be ignorant of how external worker executes. I do see this is the pattern that Python external worker follows. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org