You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/20 07:26:34 UTC
[GitHub] [incubator-doris] ccoffline opened a new pull request, #9705: [Bug] Fix disk used pct only consider the data that used by Doris
ccoffline opened a new pull request, #9705:
URL: https://github.com/apache/incubator-doris/pull/9705
# Proposed changes
Issue Number: close #9704
## Problem Summary:
Calculate the disk used pct instead of data used pct.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] carlvinhust2012 commented on a diff in pull request #9705: [Bug] Fix disk used pct only consider the data that used by Doris
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #9705:
URL: https://github.com/apache/incubator-doris/pull/9705#discussion_r877918676
##########
fe/fe-core/src/main/java/org/apache/doris/clone/BackendLoadStatistic.java:
##########
@@ -187,7 +187,7 @@ public void init() throws LoadBalanceException {
RootPathLoadStatistic pathStatistic = new RootPathLoadStatistic(beId, diskInfo.getRootPath(),
diskInfo.getPathHash(), diskInfo.getStorageMedium(),
- diskInfo.getTotalCapacityB(), diskInfo.getDataUsedCapacityB(), diskInfo.getState());
+ diskInfo.getTotalCapacityB(), diskInfo.getDiskUsedCapacityB(), diskInfo.getState());
Review Comment:
your means that it should statistic the usage of disk instead of the data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9705: [Bug] Fix disk used pct only consider the data that used by Doris
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9705:
URL: https://github.com/apache/incubator-doris/pull/9705#issuecomment-1151144656
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9705: [Bug] Fix disk used pct only consider the data that used by Doris
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9705:
URL: https://github.com/apache/incubator-doris/pull/9705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9705: [Bug] Fix disk used pct only consider the data that used by Doris
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9705:
URL: https://github.com/apache/incubator-doris/pull/9705#issuecomment-1156159952
quick merge because it has been approve several days ago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on a diff in pull request #9705: [Bug] Fix disk used pct only consider the data that used by Doris
Posted by GitBox <gi...@apache.org>.
ccoffline commented on code in PR #9705:
URL: https://github.com/apache/incubator-doris/pull/9705#discussion_r879019111
##########
fe/fe-core/src/main/java/org/apache/doris/clone/BackendLoadStatistic.java:
##########
@@ -187,7 +187,7 @@ public void init() throws LoadBalanceException {
RootPathLoadStatistic pathStatistic = new RootPathLoadStatistic(beId, diskInfo.getRootPath(),
diskInfo.getPathHash(), diskInfo.getStorageMedium(),
- diskInfo.getTotalCapacityB(), diskInfo.getDataUsedCapacityB(), diskInfo.getState());
+ diskInfo.getTotalCapacityB(), diskInfo.getDiskUsedCapacityB(), diskInfo.getState());
Review Comment:
Yes, and it seems that `TDisk.getDataUsedCapacity()` only counts all tablets, which means it ignores trash, meta and log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9705: [Bug] Fix disk used pct only consider the data that used by Doris
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9705:
URL: https://github.com/apache/incubator-doris/pull/9705#issuecomment-1151144615
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org