You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/09/02 22:48:55 UTC
Review Request 51618: GEODE-1836: remove defunct Java 1.6 block for
Mac from GFSH script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51618/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Jinmei Liao, John Blum, William Markito, and Swapnil Bawaskar.
Bugs: GEODE-1836
https://issues.apache.org/jira/browse/GEODE-1836
Repository: geode
Description
-------
GEODE-1836: remove defunct Java 1.6 block for Mac
Geode requires Java 1.8 and does not support Java 1.6. Attempting to
add the 1.6 classes.jar to the classpath for the Attach API results in
breaking the start and status commands in GFSH.
Removal of these script lines allows GFSH to use either the Attach API
in Java 1.8 or an alternative implementation for start and status. The
alternative implementation uses temporary files to communcate with the
other process. If you want to make sure you are using the Attach API
then simply set JAVA_HOME to the location of JDK 1.8.
If you use jenv on Mac, then consider configuring jenv to export
JAVA_HOME by executing:
$ jenv enable-plugin export
Diffs
-----
geode-assembly/src/main/dist/bin/gfsh 935a24e
Diff: https://reviews.apache.org/r/51618/diff/
Testing
-------
manual testing on Mac and Linux
Thanks,
Kirk Lund
Re: Review Request 51618: GEODE-1836: remove defunct Java 1.6 block
for Mac from GFSH script
Posted by Kirk Lund <ki...@gmail.com>.
> On Sept. 2, 2016, 11:11 p.m., John Blum wrote:
> > geode-assembly/src/main/dist/bin/gfsh, line 121
> > <https://reviews.apache.org/r/51618/diff/1/?file=1490685#file1490685line121>
> >
> > Maybe rather then complete remove the block... we could output a warning message to std error to inform/warn the user to install a JDK.
> >
> > Of course, my point maybe moot since I seem to remember that we no longer require a JDK and subsequently the tools.jar for Gfsh to perform correctly??
> >
> > If tools.jar is not present, it resorts to the old file-based approach, yes?
> >
> > If so, completely ignore my comment.
> >
> > I do think relying on any form of file system paths (especially absolute paths) in a given OS for a particular bit of software (e.g. JDK or other) is dangerous and always subject to change.
Yeah, it uses the file-based implementation if the Attach API can't be loaded.
- Kirk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51618/#review147710
-----------------------------------------------------------
On Sept. 2, 2016, 10:48 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51618/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 10:48 p.m.)
>
>
> Review request for geode, Anthony Baker, Jinmei Liao, John Blum, William Markito, and Swapnil Bawaskar.
>
>
> Bugs: GEODE-1836
> https://issues.apache.org/jira/browse/GEODE-1836
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1836: remove defunct Java 1.6 block for Mac
>
> Geode requires Java 1.8 and does not support Java 1.6. Attempting to
> add the 1.6 classes.jar to the classpath for the Attach API results in
> breaking the start and status commands in GFSH.
>
> Removal of these script lines allows GFSH to use either the Attach API
> in Java 1.8 or an alternative implementation for start and status. The
> alternative implementation uses temporary files to communcate with the
> other process. If you want to make sure you are using the Attach API
> then simply set JAVA_HOME to the location of JDK 1.8.
>
> If you use jenv on Mac, then consider configuring jenv to export
> JAVA_HOME by executing:
>
> $ jenv enable-plugin export
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/bin/gfsh 935a24e
>
> Diff: https://reviews.apache.org/r/51618/diff/
>
>
> Testing
> -------
>
> manual testing on Mac and Linux
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 51618: GEODE-1836: remove defunct Java 1.6 block
for Mac from GFSH script
Posted by John Blum <jb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51618/#review147710
-----------------------------------------------------------
Ship it!
If the below comment concerning warning the user does not make sense, then ship it!
geode-assembly/src/main/dist/bin/gfsh
<https://reviews.apache.org/r/51618/#comment214924>
Maybe rather then complete remove the block... we could output a warning message to std error to inform/warn the user to install a JDK.
Of course, my point maybe moot since I seem to remember that we no longer require a JDK and subsequently the tools.jar for Gfsh to perform correctly??
If tools.jar is not present, it resorts to the old file-based approach, yes?
If so, completely ignore my comment.
I do think relying on any form of file system paths (especially absolute paths) in a given OS for a particular bit of software (e.g. JDK or other) is dangerous and always subject to change.
- John Blum
On Sept. 2, 2016, 10:48 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51618/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 10:48 p.m.)
>
>
> Review request for geode, Anthony Baker, Jinmei Liao, John Blum, William Markito, and Swapnil Bawaskar.
>
>
> Bugs: GEODE-1836
> https://issues.apache.org/jira/browse/GEODE-1836
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1836: remove defunct Java 1.6 block for Mac
>
> Geode requires Java 1.8 and does not support Java 1.6. Attempting to
> add the 1.6 classes.jar to the classpath for the Attach API results in
> breaking the start and status commands in GFSH.
>
> Removal of these script lines allows GFSH to use either the Attach API
> in Java 1.8 or an alternative implementation for start and status. The
> alternative implementation uses temporary files to communcate with the
> other process. If you want to make sure you are using the Attach API
> then simply set JAVA_HOME to the location of JDK 1.8.
>
> If you use jenv on Mac, then consider configuring jenv to export
> JAVA_HOME by executing:
>
> $ jenv enable-plugin export
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/bin/gfsh 935a24e
>
> Diff: https://reviews.apache.org/r/51618/diff/
>
>
> Testing
> -------
>
> manual testing on Mac and Linux
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 51618: GEODE-1836: remove defunct Java 1.6 block
for Mac from GFSH script
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51618/#review147882
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On Sept. 2, 2016, 10:48 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51618/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 10:48 p.m.)
>
>
> Review request for geode, Anthony Baker, Jinmei Liao, John Blum, William Markito, and Swapnil Bawaskar.
>
>
> Bugs: GEODE-1836
> https://issues.apache.org/jira/browse/GEODE-1836
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1836: remove defunct Java 1.6 block for Mac
>
> Geode requires Java 1.8 and does not support Java 1.6. Attempting to
> add the 1.6 classes.jar to the classpath for the Attach API results in
> breaking the start and status commands in GFSH.
>
> Removal of these script lines allows GFSH to use either the Attach API
> in Java 1.8 or an alternative implementation for start and status. The
> alternative implementation uses temporary files to communcate with the
> other process. If you want to make sure you are using the Attach API
> then simply set JAVA_HOME to the location of JDK 1.8.
>
> If you use jenv on Mac, then consider configuring jenv to export
> JAVA_HOME by executing:
>
> $ jenv enable-plugin export
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/bin/gfsh 935a24e
>
> Diff: https://reviews.apache.org/r/51618/diff/
>
>
> Testing
> -------
>
> manual testing on Mac and Linux
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 51618: GEODE-1836: remove defunct Java 1.6 block
for Mac from GFSH script
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51618/#review148051
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Duling
On Sept. 2, 2016, 3:48 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51618/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 3:48 p.m.)
>
>
> Review request for geode, Anthony Baker, Jinmei Liao, John Blum, William Markito, and Swapnil Bawaskar.
>
>
> Bugs: GEODE-1836
> https://issues.apache.org/jira/browse/GEODE-1836
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1836: remove defunct Java 1.6 block for Mac
>
> Geode requires Java 1.8 and does not support Java 1.6. Attempting to
> add the 1.6 classes.jar to the classpath for the Attach API results in
> breaking the start and status commands in GFSH.
>
> Removal of these script lines allows GFSH to use either the Attach API
> in Java 1.8 or an alternative implementation for start and status. The
> alternative implementation uses temporary files to communcate with the
> other process. If you want to make sure you are using the Attach API
> then simply set JAVA_HOME to the location of JDK 1.8.
>
> If you use jenv on Mac, then consider configuring jenv to export
> JAVA_HOME by executing:
>
> $ jenv enable-plugin export
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/bin/gfsh 935a24e
>
> Diff: https://reviews.apache.org/r/51618/diff/
>
>
> Testing
> -------
>
> manual testing on Mac and Linux
>
>
> Thanks,
>
> Kirk Lund
>
>