[GitHub] [spark] MaxGekk commented on a change in pull request #31995: [SPARK-34900][TEST] Make sure benchmarks can run using spark-submit cmd described in the guide

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #31995:
URL: https://github.com/apache/spark/pull/31995#discussion_r603407358



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertTableWithDynamicPartitionsBenchmark.scala
##########
@@ -23,7 +23,9 @@ import org.apache.spark.benchmark.Benchmark
  * Benchmark to measure insert into table with dynamic partition columns.
  * To run this benchmark:
  * {{{
- *   1. without sbt: bin/spark-submit --class <this class> <spark sql test jar>
+ *   1. without sbt:
+ *      bin/spark-submit --class <this class>
+ *        --jars <spark core test jar>,<spark catalyst test jar> < spark sql test jar>

Review comment:
       nit: `< spark sql test jar>` -> `<spark sql test jar>`

##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/PrimitiveArrayBenchmark.scala
##########
@@ -23,7 +23,9 @@ import org.apache.spark.sql.SparkSession
 /**
  * Benchmark primitive arrays via DataFrame and Dataset program using primitive arrays
  * To run this benchmark:
- * 1. without sbt: bin/spark-submit --class <this class> <spark sql test jar>
+ * 1. without sbt:
+ *    bin/spark-submit --class <this class>
+ *      --jars <spark core test jar>,<spark catalyst test jar> < spark sql test jar>

Review comment:
       nit: `< spark sql test jar>` -> `<spark sql test jar>`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org