Change in asterixdb[master]: Configuration Revamp

["Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>]

Till Westmann has posted comments on this change.

Change subject: Configuration Revamp
......................................................................


Patch Set 33:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm:

PS33, Line 26: metadata
Do we have/need tests for the config APIs that contain the information that is not reported here anymore?


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java:

PS33, Line 21: .*;
Expand * include.


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
File asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh:

PS33, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixInstallerIntegrationUtil.java
File asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixInstallerIntegrationUtil.java:

PS33, Line 129: sleep
Why do we need this now?


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java:

Line 79:     private CCConfig ccConfig;
> MAJOR SonarQube violation:
Good point.


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java:

PS33, Line 287: commandLineOptions
Even though this is really efficient wrt screen real estate , splitting it up might be a bit more readable :)


PS33, Line 390: recieve
s/recieve/receive/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes