You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/01/22 16:27:09 UTC
[GitHub] kasjer commented on a change in pull request #1608:
hw/drivers/spiflash: Add auto power down
kasjer commented on a change in pull request #1608: hw/drivers/spiflash: Add auto power down
URL: https://github.com/apache/mynewt-core/pull/1608#discussion_r249852921
##########
File path: hw/drivers/flash/spiflash/include/spiflash/spiflash.h
##########
@@ -97,6 +100,11 @@ struct spiflash_chip {
int spiflash_init(const struct hal_flash *dev);
+void spiflash_power_down(struct spiflash_dev *dev);
+void spiflash_release_power_down_macronix(struct spiflash_dev *dev);
Review comment:
This one is my fault, but since we have this nice PR maybe spi_flash_release_power_down should be the only one release power down that would call device specific version.
In this case macronix and non-macronix version would be private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services