You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/11/19 01:53:33 UTC
Review Request 15658: Increased the minimum number of threads that
libprocess statically allocates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15658/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-818
https://issues.apache.org/jira/browse/MESOS-818
Repository: mesos-git
Description
-------
- This is for https://issues.apache.org/jira/browse/MESOS-818 which caused problem running some tests in the next review.
Diffs
-----
3rdparty/libprocess/src/process.cpp 0cc0acef2b5daa7da6b629f646b78151521e03fc
Diff: https://reviews.apache.org/r/15658/diff/
Testing
-------
tested with master contender.
Thanks,
Jiang Yan Xu
Re: Review Request 15658: Increased the minimum number of threads that
libprocess statically allocates.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15658/#review29090
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/15658/#comment56218>
s/use/Use/
Can you expand a bit more on the comment on why we need more threads?
- Vinod Kone
On Nov. 19, 2013, 12:53 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15658/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 12:53 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-818
> https://issues.apache.org/jira/browse/MESOS-818
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - This is for https://issues.apache.org/jira/browse/MESOS-818 which caused problem running some tests in the next review.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 0cc0acef2b5daa7da6b629f646b78151521e03fc
>
> Diff: https://reviews.apache.org/r/15658/diff/
>
>
> Testing
> -------
>
> tested with master contender.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 15658: Increased the minimum number of threads that
libprocess statically allocates.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15658/#review29089
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 19, 2013, 12:53 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15658/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 12:53 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-818
> https://issues.apache.org/jira/browse/MESOS-818
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - This is for https://issues.apache.org/jira/browse/MESOS-818 which caused problem running some tests in the next review.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 0cc0acef2b5daa7da6b629f646b78151521e03fc
>
> Diff: https://reviews.apache.org/r/15658/diff/
>
>
> Testing
> -------
>
> tested with master contender.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 15658: Increased the minimum number of threads that
libprocess statically allocates.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15658/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 1:29 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Changes
-------
Vinod's comments.
Bugs: MESOS-818
https://issues.apache.org/jira/browse/MESOS-818
Repository: mesos-git
Description
-------
- This is for https://issues.apache.org/jira/browse/MESOS-818 which caused problem running some tests in the next review.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 0cc0acef2b5daa7da6b629f646b78151521e03fc
Diff: https://reviews.apache.org/r/15658/diff/
Testing
-------
tested with master contender.
Thanks,
Jiang Yan Xu