You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Vít Rozkovec (JIRA)" <ji...@apache.org> on 2018/02/21 15:54:00 UTC

[jira] [Created] (WICKET-6539) Scope fix for DataTable toolbars

Vít Rozkovec created WICKET-6539:
------------------------------------

             Summary: Scope fix for DataTable toolbars
                 Key: WICKET-6539
                 URL: https://issues.apache.org/jira/browse/WICKET-6539
             Project: Wicket
          Issue Type: Bug
          Components: wicket-extensions
    Affects Versions: 8.0.0-M8
            Reporter: Vít Rozkovec


{{I've come across one inconsistency in the DataTable class: }}

{{    /** }}
{{     * @return the container with the toolbars at the top }}
{{     */ }}
{{    public final ToolbarsContainer getTopToolbars() }}
{{    { }}
{{        return topToolbars; }}
{{    } }}

{{    /** }}
{{     * @return the container with the toolbars at the bottom }}
{{     */ }}
{{    public final ToolbarsContainer getBottomToolbars() }}
{{    { }}
{{        return bottomToolbars; }}
{{    } }}



{{ToolbarsContainer is defined as private, so those methods cannot be used anyway. I suggest either changing the visibility of ToolbarsContainer or removing those methods. I've searched for references and there are not any, though I came across one usecase where I needed to refresh toolbars after ajax update.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)