[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1764: [split/7] move built-in scalar function to datafusion-expr

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764#discussion_r801643132



##########
File path: datafusion-expr/src/built_in_function.rs
##########
@@ -0,0 +1,330 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       is the plan to move the built in aggregate functions here too?

##########
File path: datafusion-expr/src/lib.rs
##########
@@ -16,12 +16,14 @@
 // under the License.
 
 mod aggregate_function;

Review comment:
       I also like how this reorganization is making the structure of `Expr` easier to understand 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org