[jira] [Commented] (MCHECKSTYLE-104) CheckstyleViolationCheckMojo: More flexible checkstyle:check-inflicted build failures

["Elliotte Rusty Harold (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000014#comment-17000014 ] 

Elliotte Rusty Harold commented on MCHECKSTYLE-104:
---------------------------------------------------

Might be useful if anyone wants to pick this up.

> CheckstyleViolationCheckMojo: More flexible checkstyle:check-inflicted build failures
> -------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-104
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-104
>             Project: Maven Checkstyle Plugin
>          Issue Type: New Feature
>          Components: checkstyle:check
>    Affects Versions: 2.2
>            Reporter: Kaloyan Enimanev
>            Priority: Major
>         Attachments: CheckstyleViolationCheckMojo.java
>
>
> Hey guys,
>   first of all let me thank you for the wonderful job that you all do.  Our company's build process has rocketed a century forward after we replaced Ant with Maven.
>   We're currently trying to migrate from Maven1 to Maven2. We have a Jelly goal  in our old M1 build that does similar job to "checkstyle:check" in M2,  but it verifies that a project does not have more than {{X}} Checkstyle Errors *and* {{Y}} Checkstyle Warnings.  That was not entirely possible to configure with M2, where one can choose to fail the build on more than 0 Errors *or* Warnings, where 0 is not a configurable value in contrast with {{X}} and {{Y}}.
> I have scribbled several changes in 
> {{/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java}}
> where I basically replaced the parameter {{violationSeverity}} with 3 new parameters ({{maxErrors}}, {{maxWarnings}}, {{maxInfos}}) allowing the user a more flexible configuration  of checkstyle-inflicted build failures. 
> Example :
> The configuration
> {code:xml}
> <plugin>
>   <artifactId>maven-checkstyle-plugin</artifactId>
>   <configuration>
>     <failsOnError>true</failsOnError>
>     <maxErrors>0</maxErrors>
>     <maxWarnings>100</maxWarnings>
>      .....
>   </configuration>
> ......
> {code}
> will fail the build of a project that has more than 0 Checkstyle Errors or more than 100 Checkstyle Warnings.
> If you find such the feature useful and want to include it in some of the next releases of {{maven-checkstyle-plugin}} I will be happy to do the additional Documentation/Test Cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)