[jira] [Commented] (SYNAPSE-1061) WeightedRRLCAlgorithm Unwanted condition

["Isuru Udana Loku Narangoda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNAPSE-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685377#comment-15685377 ] 

Isuru Udana Loku Narangoda commented on SYNAPSE-1061:
-----------------------------------------------------

Hi Vanji,

Shall we try to understand the logic behind reCalcuateWeight().

I am just wondering whether we have mistakenly put 

{code}
if (totalConnections > 0)
{code}

instead of 
{code}
if (totalConnections >= 0)
{code}

because totalConnections == 0 is explicitly handled within the method, which gives the idea that we need to recalculate the weight for that case as well. 


>  WeightedRRLCAlgorithm Unwanted condition
> -----------------------------------------
>
>                 Key: SYNAPSE-1061
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-1061
>             Project: Synapse
>          Issue Type: Bug
>            Reporter: Vanjikumaran Sivajothy
>            Assignee: Hiranya Jayathilaka
>         Attachments: SYNAPSE-1061.diff
>
>
>  was going through with WeightedRRLCAlgorithm and noticed that useless condition used in reCalcuateWeight(). Why do we need that condition over there and it is already known that totalConnections is not a zero.
> {code}
>  public void reCalcuateWeight() {
>             if (totalConnections > 0) {
>                 double weightRatio = (double) fixedWeight / totalWeight;
>                 double connectionRatio;
>                 if (totalConnections != 0) { //useless condition...??
>                     connectionRatio = (double) currentConnectionCount / totalConnections;
>                 } else {
>                     connectionRatio = 0;
>                 }
>                 double diff = weightRatio - connectionRatio;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org