[jira] [Commented] (RATIS-143) RaftClientImpl should have upper bound on async requests

["Mukul Kumar Singh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253952#comment-16253952 ] 

Mukul Kumar Singh commented on RATIS-143:
-----------------------------------------

Thanks for the patch [~ljain], The patch looks good, couple of comments.

1) RaftClientImpl:52, can we make this a configuration variable ? this will determine the command queue length and having a configuration variable will enable us to run with different configs. The queue length can be determined in the builder and then passed along.
2) We will also have to handle the code, where an application closes the RaftClient while there are threads blocked on the semaphore.
3) We will need license on the test files. 

> RaftClientImpl should have upper bound on async requests
> --------------------------------------------------------
>
>                 Key: RATIS-143
>                 URL: https://issues.apache.org/jira/browse/RATIS-143
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>         Attachments: RATIS-143.001.patch
>
>
> RaftClientImpl should have a upper bound on active async requests. Further request should be blocked until the active one is handled. Idea is to use semaphore so that a request is blocked until a permit is released by one of the active ones.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)