You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "furqaankhan (via GitHub)" <gi...@apache.org> on 2024/05/17 18:20:38 UTC
[PR] [SEDONA-558] Fix and improve SedonaPyDeck behavior [sedona]
furqaankhan opened a new pull request, #1415:
URL: https://github.com/apache/sedona/pull/1415
## Did you read the Contributor Guide?
- Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
## Is this PR related to a JIRA ticket?
- Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-558. The PR name follows the format `[SEDONA-XXX] my subject`
## Description
### Current implementation
- Adds the optional parameters `map_style`, and `map_provider` as data members to the pdk map object.
eg: map_p.map_style = map_style
- The current behavior of PyDeck doesn't update the map object with the additional configuration added via data members.
### Behavior of PyDeck
- The default `map_style` is 'dark' and `map_provider` is 'carto'. If you configure `map_style` to 'satellite' it will not change the `map_provider` to Mapbox or Google Maps API.
## What changes were proposed in this PR?
- Expose `api_key` parameter of PyDeck
- If `MAPBOX_API_KEY` env variable is available, it will use it by default.
- Create a new method to create the PyDeck object to handle the default behavior of PyDeck.
- Default to Mapbox map provider if the `map_style` is set to 'satellite' and if `map_provider` is Carto (the default).
## How was this patch tested?
- Passed existing tests.
## Did this PR include necessary documentation updates?
- Yes, I have updated the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-558] Fix and improve SedonaPyDeck behavior [sedona]
Posted by "furqaankhan (via GitHub)" <gi...@apache.org>.
furqaankhan commented on code in PR #1415:
URL: https://github.com/apache/sedona/pull/1415#discussion_r1605473328
##########
python/tests/sql/test_dataframe_api.py:
##########
Review Comment:
They are phony changes, these changes have been merged before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-558] Fix and improve SedonaPyDeck behavior [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1415:
URL: https://github.com/apache/sedona/pull/1415#discussion_r1605433529
##########
python/tests/sql/test_dataframe_api.py:
##########
Review Comment:
Why is this PR changing these files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-558] Fix and improve SedonaPyDeck behavior [sedona]
Posted by "furqaankhan (via GitHub)" <gi...@apache.org>.
furqaankhan commented on PR #1415:
URL: https://github.com/apache/sedona/pull/1415#issuecomment-2118289415
To test if the API key has been added successfully [is not possible](https://github.com/visgl/deck.gl/blob/b738b66e97fef8995daa8b5d9470dfbfe2fdc9c2/bindings/pydeck/pydeck/bindings/json_tools.py#L8-L17). However, I can add tests for other behavior changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-558] Fix and improve SedonaPyDeck behavior [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1415:
URL: https://github.com/apache/sedona/pull/1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org