[jira] [Commented] (SQOOP-1795) Sqoop2: Retrieve Http post data in plausible manner

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222816#comment-14222816 ] 

Sqoop QA bot commented on SQOOP-1795:
-------------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12683299/SQOOP-1795.patch against branch sqoop2.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} Patch does not add/modifny any test case
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All tests passed

Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/662/console

This message is automatically generated.

> Sqoop2: Retrieve Http post data in plausible manner
> ---------------------------------------------------
>
>                 Key: SQOOP-1795
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1795
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Qian Xu
>            Assignee: Qian Xu
>            Priority: Minor
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1795.patch
>
>
> The situation of dealing with the post data is very tricky IMHO. 
> 1. {{getRequest().getReader()}} must be called at the first place. As reader cannot go back to head, it's state is mutable. It any *invisible* invocation of {{getReader()}} happened, it will be very hard to track down the problem., such as SQOOP-1784.
> 2. The current code assumes the post data to be valid JSON object. Usually it'd be better wrapped into an object, such as "jsonObject", so that we can call {{ctx.getParameterValue("jsonObject")}}.
> I'd provide a {{getRawPostData()}} so that callers can put finger away from {{getReader()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)