[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #13001: Fix incorrect timeout message

["AlbumenJ (via GitHub)" <gi...@apache.org>]

AlbumenJ commented on code in PR #13001:
URL: https://github.com/apache/dubbo/pull/13001#discussion_r1314663068


##########
dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/exchange/support/DefaultFutureTest.java:
##########
@@ -86,6 +86,44 @@ public void timeoutNotSend() throws Exception {
         }
     }
 
+    /**
+     * for example, it will print like this:
+     * before a future is created, time is : 2023-09-03 18:20:14.535
+     * after a future is timeout, time is : 2023-09-03 18:20:14.669
+     * <p>
+     * The exception info print like:
+     * Sending request timeout in client-side by scan timer.
+     * start time: 2023-09-03 18:20:14.544, end time: 2023-09-03 18:20:14.598...
+     */
+    @Test
+    @Disabled

Review Comment:
   Why dieable it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org